Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scripts): publish script #354

Merged
merged 2 commits into from
Jun 4, 2021
Merged

chore(scripts): publish script #354

merged 2 commits into from
Jun 4, 2021

Conversation

niklasad1
Copy link
Member

No description provided.

@dvdplm
Copy link
Contributor

dvdplm commented Jun 2, 2021

@tomusdrw 's script seems to do a bit more than this and has been working well over there, just saying. :)

@niklasad1
Copy link
Member Author

yeah, it's inspired by that ofcourse but I want to actually check all crates could be published before creating the tag

but we could use https://github.com/paritytech/cargo-unleash perhaps instead.

@dvdplm
Copy link
Contributor

dvdplm commented Jun 2, 2021

but we could use https://github.com/paritytech/cargo-unleash perhaps instead.

oh, I like that idea.

@tomusdrw
Copy link
Contributor

tomusdrw commented Jun 2, 2021

but I want to actually check all crates could be published before creating the tag

You can still do that with my script just passing --dry-run to parameters (note $@ near cargo publish).

However it only works if the published crates can use older (already published) versions. I.e. it won't work if you do a major release and have dependent crates for instance.

@niklasad1
Copy link
Member Author

You can still do that with my script just passing --dry-run to parameters (note $@ near cargo publish).

Right, my bash reading skillz are poor nowdays.

However it only works if the published crates can use older (already published) versions. I.e. it won't work if you do a major release and have dependent crates for instance.

yeah good point

@dvdplm dvdplm marked this pull request as ready for review June 4, 2021 11:48
@dvdplm dvdplm merged commit a3feec7 into master Jun 4, 2021
@dvdplm dvdplm deleted the na-publish-script branch June 4, 2021 11:57
dvdplm added a commit that referenced this pull request Jul 6, 2021
@dvdplm
Merge branch 'master' into dp-all-requests-timeout
1085a02 
* master: (21 commits)
  New proc macro (#387)
  Streaming RpcParams parsing (#401)
  Set allowed Host header values (#399)
  Synchronization-less async connections in ws-server (#388)
  [ws server]: terminate already established connection(s) when the server is stopped (#396)
  feat: customizable JSON-RPC error codes via new enum variant on `CallErrror` (#394)
  [ci]: test each individual crate's manifest (#392)
  Add a way to stop servers (#386)
  [jsonrpsee types]: unify a couple of types + more tests (#389)
  Update roadmap link in readme (#390)
  Cross-origin protection (#375)
  Method aliases + RpcModule: Clone (#383)
  Use criterion's async bencher (#385)
  Async/subscription benches (#372)
  send text (#374)
  Fix link to ws server in README.md (#373)
  Concat -> simple push (#370)
  Add missing `rt` feature (#369)
  Release prep for v0.2 (#368)
  chore(scripts): publish script (#354)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @dvdplm @tomusdrw