Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming RpcParams parsing #401

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Streaming RpcParams parsing #401

merged 3 commits into from
Jul 1, 2021

Conversation

maciejhirsz
Copy link
Contributor

This is an alternative to #391.

RpcParams now has two new methods, next and optional_next, which yields the next value from the JSON array RpcParams was created from. optional_next will return None for null or for missing elements (it will still error when parsing a wrong type or invalid JSON).

@niklasad1 niklasad1 mentioned this pull request Jul 1, 2021
Closed
@niklasad1
Copy link
Member

Clean as always but we need add some additional code for this in macros to work smoothly ^

@maciejhirsz maciejhirsz merged commit 095db9b into master Jul 1, 2021
@maciejhirsz maciejhirsz deleted the mh-streaming-params-parser branch July 1, 2021 16:12
This was referenced Jul 1, 2021
Closed
Closed
dvdplm added a commit that referenced this pull request Jul 6, 2021
@dvdplm
Merge branch 'master' into dp-all-requests-timeout
1085a02 
* master: (21 commits)
  New proc macro (#387)
  Streaming RpcParams parsing (#401)
  Set allowed Host header values (#399)
  Synchronization-less async connections in ws-server (#388)
  [ws server]: terminate already established connection(s) when the server is stopped (#396)
  feat: customizable JSON-RPC error codes via new enum variant on `CallErrror` (#394)
  [ci]: test each individual crate's manifest (#392)
  Add a way to stop servers (#386)
  [jsonrpsee types]: unify a couple of types + more tests (#389)
  Update roadmap link in readme (#390)
  Cross-origin protection (#375)
  Method aliases + RpcModule: Clone (#383)
  Use criterion's async bencher (#385)
  Async/subscription benches (#372)
  send text (#374)
  Fix link to ws server in README.md (#373)
  Concat -> simple push (#370)
  Add missing `rt` feature (#369)
  Release prep for v0.2 (#368)
  chore(scripts): publish script (#354)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciejhirsz @niklasad1 @dvdplm