This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
More Backports for Stable 2.3.5 #10430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @HCastano signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
HCastano
commented
Feb 27, 2019
| @@ -184,6 +186,11 @@ fn main_direct(force_can_restart: bool) -> i32 { | |||
| parity_ethereum::Configuration::parse_cli(&args).unwrap_or_else(|e| e.exit()) | |||
| }; | |||
|
|
|||
| let logger = setup_log(&conf.logger_config()).unwrap_or_else(|e| { | |||
There was a problem hiding this comment.
There's a warning here about this being unused. This is because it only started getting used in #10007 which isn't in stable yet. Not sure if I should leave the warning, or not backport this PR in yet
soc1c
added
A8-backport 🕸
…penethereum#10417) * update foundation to #7262209 * update kovan to #10434561 * update ropsten to #5027841 * update classic to #7555073 * Update Ropsten headers to #5101569
soc1c
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.