Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pallet::getter usage from pallet-aura #3330

Closed
k-gunjan opened this issue Feb 15, 2024 · 1 comment · Fixed by #3350
Closed

remove pallet::getter usage from pallet-aura #3330

k-gunjan opened this issue Feb 15, 2024 · 1 comment · Fixed by #3350
Assignees
@k-gunjan

Comments

@k-gunjan
Copy link
Contributor

This issue implements the removal of pallet::getter in pallet-aura, as per #3326.
Discussion on the issue is here #223.
@github-actions github-actions bot added the I10-unconfirmed Issue might be valid, but it's not yet known. label Feb 15, 2024
@ggwpez ggwpez removed the I10-unconfirmed Issue might be valid, but it's not yet known. label Feb 15, 2024
@k-gunjan k-gunjan mentioned this issue Feb 16, 2024
Merged
@kianenigma
Copy link
Contributor

Thank you, but there is no need for a separate issue per pallet, let's continue in the PR.

github-merge-queue bot pushed a commit that referenced this issue Mar 18, 2024
@k-gunjan @bkchr
Pallet AURA: remove pallet::getter macro and write the corresponding …
816c072 
…code (#3350)

Removed the `pallet::getter` macro call from storage type definitions
and added the corresponding implementations directly.
fixes #3330  

polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Mar 24, 2024
@k-gunjan @bkchr @dharjeezy
Pallet AURA: remove pallet::getter macro and write the corresponding …
933d857 
…code (paritytech#3350)

Removed the `pallet::getter` macro call from storage type definitions
and added the corresponding implementations directly.
fixes paritytech#3330  

polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k-gunjan k-gunjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pallet AURA: remove pallet::getter macro and write the corresponding code k-gunjan/polkadot-sdk
3 participants
@kianenigma @ggwpez @k-gunjan