Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pallet AURA: remove pallet::getter macro and write the corresponding code #3350

Merged
merged 25 commits into from
Mar 18, 2024
Merged

Pallet AURA: remove pallet::getter macro and write the corresponding code #3350

merged 25 commits into from
Mar 18, 2024

Conversation

k-gunjan
Copy link
Contributor

@k-gunjan k-gunjan commented Feb 16, 2024 •
edited
Loading

Removed the pallet::getter macro call from storage type definitions and added the corresponding implementations directly.
fixes #3330

polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz

@k-gunjan k-gunjan requested a review from a team as a code owner February 16, 2024 07:35
@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 16, 2024

User @k-gunjan, please sign the CLA here.

@davxy davxy changed the title remove pallet::getter macro and write the corresponding code Pallet AURA: remove pallet::getter macro and write the corresponding code Feb 16, 2024
@franciscoaguirre franciscoaguirre added the R0-silent Changes should not be mentioned in any release notes label Feb 19, 2024
@muraca muraca mentioned this pull request Feb 19, 2024
Open
63 tasks
muraca
muraca suggested changes Feb 19, 2024
View reviewed changes
substrate/frame/aura/src/lib.rs Outdated Show resolved Hide resolved
s0me0ne-unkn0wn
s0me0ne-unkn0wn approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@s0me0ne-unkn0wn s0me0ne-unkn0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@k-gunjan k-gunjan force-pushed the gunjan-remove-getter-macro-pallet-aura-issue-3330 branch 3 times, most recently from 005d91f to 05ab1ae Compare March 6, 2024 04:12
@k-gunjan k-gunjan force-pushed the gunjan-remove-getter-macro-pallet-aura-issue-3330 branch from 9c1a94c to 9b59665 Compare March 6, 2024 10:15
@muraca
Copy link
Contributor

muraca commented Mar 8, 2024

As a breaking change, this requires the removal of the R0 label and a prdoc

bkchr
bkchr approved these changes Mar 18, 2024
View reviewed changes
substrate/frame/aura/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/aura/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/aura/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr enabled auto-merge March 18, 2024 10:04
@bkchr bkchr added this pull request to the merge queue Mar 18, 2024
Merged via the queue into paritytech:master with commit 816c072 Mar 18, 2024
130 of 132 checks passed
@k-gunjan k-gunjan deleted the gunjan-remove-getter-macro-pallet-aura-issue-3330 branch March 18, 2024 10:55
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@k-gunjan @bkchr @dharjeezy
Pallet AURA: remove pallet::getter macro and write the corresponding …
933d857 
…code (paritytech#3350)

Removed the `pallet::getter` macro call from storage type definitions
and added the corresponding implementations directly.
fixes paritytech#3330  

polkadot address: 14JzTPPUd8x8phKi8qLxHgNTnTMg6DUukCLXoWprejkaHXPz

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
@Morganamilo Morganamilo mentioned this pull request Apr 4, 2024
Closed
12 tasks
@k-gunjan
Copy link
Contributor Author

tip?

enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
- Upgrade Polkadot-sdk to v.1.10.0.
68bf043 
- Update weights to reflect the new version.

Notable Changes:
- [System Callbacks](paritytech/polkadot-sdk#1781)
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1922
@enddynayn enddynayn mentioned this pull request Jul 30, 2024
Merged
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
- Upgrade Polkadot-sdk to v.1.10.0.
eab703f 
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1922
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
- Upgrade Polkadot-sdk to v.1.10.0.
ffb04e3 
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
- Upgrade Polkadot-sdk to v.1.10.0.
474c0f9 
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
9b6fa5c 
- Upgrade Polkadot-sdk to v.1.10.0.
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
0e84494 
- Upgrade Polkadot-sdk to v.1.10.0.
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
f95ebf1 
- Upgrade Polkadot-sdk to v.1.10.0.
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 31, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
a1a69dd 
- Upgrade Polkadot-sdk to v.1.10.0.
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Aug 1, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
a829d90 
- Upgrade Polkadot-sdk to v.1.10.0.
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macr](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

issue-1928
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Aug 1, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
ebe7363 
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macro](paritytech/polkadot-sdk#3350)
- [Refactor APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)
- [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854)
- [StorageWeightReclaim SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files)

For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Aug 1, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0 (#2104)
1e83130 
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental
flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter
macro](paritytech/polkadot-sdk#3350)
- [Refactor
APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)
- [Refactor Unified Host
Functions](paritytech/polkadot-sdk#3854)
- [StorageWeightReclaim
SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

#1928

---------

Co-authored-by: enddynayn <enddynayn@users.noreply.github.com>
@chungquantin chungquantin mentioned this pull request Aug 13, 2024
Merged
rustadot pushed a commit to rustadot/recurrency that referenced this pull request Sep 5, 2024
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0 (#2104)
aa57500 
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental
flag](https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter
macro](paritytech/polkadot-sdk#3350)
- [Refactor
APIs](https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)
- [Refactor Unified Host
Functions](paritytech/polkadot-sdk#3854)
- [StorageWeightReclaim
SignedExtension](https://github.com/paritytech/polkadot-sdk/pull/3002/files)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)

#1928

---------

Co-authored-by: enddynayn <enddynayn@users.noreply.github.com>
@TDemeco TDemeco mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez left review comments

@muraca muraca muraca requested changes

@s0me0ne-unkn0wn s0me0ne-unkn0wn s0me0ne-unkn0wn approved these changes

@bkchr bkchr bkchr approved these changes

@kianenigma kianenigma kianenigma approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove pallet::getter usage from pallet-aura
7 participants
@k-gunjan @muraca @kianenigma @bkchr @ggwpez @s0me0ne-unkn0wn @franciscoaguirre