Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRDoc crate semver #3984

Closed
1 of 12 tasks
Morganamilo opened this issue Apr 4, 2024 · 8 comments
Closed
1 of 12 tasks

PRDoc crate semver #3984

Morganamilo opened this issue Apr 4, 2024 · 8 comments

Comments

@asiniscalchi
Copy link
Contributor

asiniscalchi commented Apr 4, 2024

#3817 was tagged as R0-silent so I imagine PRdoc was not needed here

@bkchr
Copy link
Member

bkchr commented Apr 4, 2024

#3817 was tagged as R0-silent so I imagine PRdoc was not needed here

I mean it is not very important to appear in the release notes. However, the sp-api-macro change is actually something that requires a minor bump. Maybe you could create a pr and make the prdoc only about this change with a minor bump for this crate?

ordian added a commit that referenced this issue Apr 4, 2024
Properly account for #3302, cc #3984.
@ggwpez
Copy link
Member

ggwpez commented Apr 4, 2024

We dont yet have CI checks that assert that the Prdoc bumps are correct.
So we cannot confidently use this to version it - yet. But it would still be good to have the tools in place to do so.

@bkchr
Copy link
Member

bkchr commented Apr 4, 2024

So, @ggwpez we don't yet need to have the correct bumps in the prdoc yet? Any idea when CI etc tooling will be ready?

@ggwpez
Copy link
Member

ggwpez commented Apr 4, 2024

So, ggwpez we don't yet need to have the correct bumps in the prdoc yet?

Yea, looks like we were not ready for it yet. Reverted here #3987

Any idea when CI etc tooling will be ready?

No. I think @Morganamilo is working on an extension for the parity-publish to detect breaking changes though.

@asiniscalchi
Copy link
Contributor

#3817 was tagged as R0-silent so I imagine PRdoc was not needed here

I mean it is not very important to appear in the release notes. However, the sp-api-macro change is actually something that requires a minor bump. Maybe you could create a pr and make the prdoc only about this change with a minor bump for this crate?

Hope it fits : #3995

github-merge-queue bot pushed a commit that referenced this issue Apr 5, 2024
Properly account for #3302, cc #3984.
@s0me0ne-unkn0wn
Copy link
Contributor

Maybe create a single co-authored PR instead of a bunch of one-liners?

@ggwpez
Copy link
Member

ggwpez commented Apr 6, 2024

We dont need it for this Release, its causing too much noise now to ping dozens of ppl. Sorry about this.

@ggwpez ggwpez closed this as completed Apr 6, 2024
Ank4n pushed a commit that referenced this issue Apr 9, 2024
Properly account for #3302, cc #3984.
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this issue Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants