Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Update rust to 1.74 #2545

Merged
merged 14 commits into from
Dec 7, 2023
Merged

[ci] Update rust to 1.74 #2545

merged 14 commits into from
Dec 7, 2023

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Nov 29, 2023 •
edited
Loading

@alvicsam alvicsam requested a review from a team as a code owner November 29, 2023 14:40
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 29, 2023 14:40
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Nov 29, 2023
@alvicsam alvicsam requested review from a team November 29, 2023 15:54
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 29, 2023 15:54
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 29, 2023 16:16
@alvicsam @seadanda
Update polkadot/node/core/prospective-parachains/src/tests.rs
637e54b 
Co-authored-by: Dónal Murray <donal.murray@parity.io>
@alvicsam
Copy link
Contributor Author

bot update-ui latest -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.74.0-2023-11-01-v20231025 --rust_version=1.74.0

@command-bot
Copy link

command-bot bot commented Nov 30, 2023 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4553842 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.74.0. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-c98d251a-4c61-4033-a1fd-0f802db67345 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 30, 2023

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.74.0 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4553842 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4553842/artifacts/download.

@alvicsam
Copy link
Contributor Author

bot update-ui latest -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.74.0-2023-11-01-v20231025 --rust_version=1.74.0

@command-bot
Copy link

command-bot bot commented Nov 30, 2023 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4560400 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.74.0. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 21-c64bdaf3-6add-4d0b-8c8f-19e748ac8217 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 30, 2023

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.74.0 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4560400 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4560400/artifacts/download.

ggwpez and others added 2 commits December 4, 2023 19:54
@ggwpez
Update UI
9d2a6e7 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@alvicsam
Merge branch 'master' into as-upd-rust
bc795f6
@bkchr
Copy link
Member

bkchr commented Dec 5, 2023

@alvicsam can we move forward?

@ggwpez
Copy link
Member

ggwpez commented Dec 5, 2023

@alvicsam can we move forward?

The UI bot somehow did not update the UI tests. I did it manually now 🤷‍♂️
Should be good to go now.

@ggwpez
Copy link
Member

ggwpez commented Dec 5, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 5, 2023 •
edited
Loading

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4620404 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-ad914ae1-db10-4a05-9816-16c67a6f09bf to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 5, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4620404 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4620404/artifacts/download.

@alvicsam
Copy link
Contributor Author

alvicsam commented Dec 6, 2023

@bkchr I would love to but this PR is blocked by srlabs team. I'm trying to figure out new audit rules and if they are applicable to this PR

@serhanwbahar serhanwbahar self-requested a review December 6, 2023 16:04
@alvicsam alvicsam mentioned this pull request Dec 6, 2023
Merged
@alvicsam alvicsam merged commit cd63276 into master Dec 7, 2023
116 checks passed
@alvicsam alvicsam deleted the as-upd-rust branch December 7, 2023 08:57
@alvicsam alvicsam mentioned this pull request Dec 7, 2023
Merged
1 task
ordian added a commit that referenced this pull request Dec 11, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-disputes
80f371e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
ordian added a commit that referenced this pull request Dec 15, 2023
@ordian
Merge branch 'tsv-disabling' into ao-disabling-statement-distribution
9842b9e 
* tsv-disabling: (155 commits)
  Fix failing rc-automation GHA (#2648)
  [ci] Return CI_IMAGE variable (#2647)
  Support querying peer reputation (#2392)
  [ci] Update rust to 1.74 (#2545)
  Relax approval requirements on CI files (#2564)
  Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422)
  Improve polkadot sdk docs (#2631)
  Bridges subtree update (#2602)
  pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388)
  [ci] Move rust-features.sh script to .gitlab folder (#2630)
  Bump parity-db from 0.4.10 to 0.4.12 (#2635)
  sp-core: Rename VrfOutput to VrfPreOutput (#2534)
  chore: fix typo (#2596)
  Bump tracing-core from 0.1.31 to 0.1.32 (#2618)
  chore: fixed std wasm build of xcm (#2535)
  Fix PRdoc that have been previously drafted with older schema (#2623)
  Github Workflow migrations (#1574)
  Bridges update subtree (#2625)
  PVF: Add Secure Validator Mode (#2486)
  statement-distribution: Add tests for incoming acknowledgements (#2498)
  ...
bkontur pushed a commit that referenced this pull request Feb 1, 2024
@alvicsam @seadanda
@bkchr @ggwpez @bkontur
[ci] Update rust to 1.74 (#2545)
353a7b2 
cc paritytech/ci_cd#900

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
franciscoaguirre pushed a commit that referenced this pull request Feb 2, 2024
@alvicsam @seadanda
@bkchr @ggwpez @franciscoaguirre
[ci] Update rust to 1.74 (#2545)
526be44 
cc paritytech/ci_cd#900

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@alvicsam @seadanda
@bkchr @ggwpez
[ci] Update rust to 1.74 (paritytech#2545)
9177e44 
cc paritytech/ci_cd#900

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergejparity sergejparity sergejparity approved these changes

@redzsina redzsina redzsina approved these changes

@serhanwbahar serhanwbahar serhanwbahar approved these changes

@seadanda seadanda seadanda approved these changes

@ggwpez ggwpez ggwpez approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@bkchr bkchr bkchr approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alvicsam @bkchr @ggwpez @EgorPopelyaev @seadanda @serhanwbahar @redzsina @sergejparity