Improve polkadot sdk docs #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juangirini
added
R0-silent
liamaharon
approved these changes
Dec 5, 2023
gpestana
approved these changes
Dec 6, 2023
| //! | ||
| //! As noted above, the `T::AccountId` is now `u64`. Moreover, `Runtime` is replacing `<T: Config>`. | ||
| //! This is why for example you see `Balances::<Runtime>::get(..)`. Finally, notice that the | ||
| //! dispatchables are simply functions that can be called on top of the `Pallet` struct. | ||
| //! | ||
| //! TODO: hard to explain exactly `RuntimeOrigin::signed(1)` at this point. | ||
| // TODO: hard to explain exactly `RuntimeOrigin::signed(ALICE)` at this point. |
There was a problem hiding this comment.
Suggested change
| // TODO: hard to explain exactly `RuntimeOrigin::signed(ALICE)` at this point. | |
| // TODO: hard to explain exactly `RuntimeOrigin::signed(Alice)` at this point. |
There was a problem hiding this comment.
I would leave the proper case to not code only
| @@ -186,8 +186,8 @@ | |||
| #![doc = docify::embed!("./src/guides/your_first_pallet/mod.rs", StateBuilder)] | |||
| //! | |||
| //! This struct is meant to contain the same list of accounts and balances that we want to have at | |||
| //! the beginning of each block. We hardcoded this to `let accounts = vec![(1, 100), (2, 100)];` so | |||
| //! far. Then, if desired, we attach a default value for this struct. | |||
| //! the beginning of each block. We hardcoded this to `let accounts = vec![(ALICE, 100), (2, 100)];` | |||
There was a problem hiding this comment.
Suggested change
| //! the beginning of each block. We hardcoded this to `let accounts = vec![(ALICE, 100), (2, 100)];` | |
| //! the beginning of each block. We hardcoded this to `let accounts = vec![(Alice, 100), (2, 100)];` |
There was a problem hiding this comment.
I would leave the proper case to not code only
franciscoaguirre
approved these changes
Dec 6, 2023
ordian
added a commit
that referenced
this pull request
Dec 11, 2023
* tsv-disabling: (155 commits) Fix failing rc-automation GHA (#2648) [ci] Return CI_IMAGE variable (#2647) Support querying peer reputation (#2392) [ci] Update rust to 1.74 (#2545) Relax approval requirements on CI files (#2564) Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422) Improve polkadot sdk docs (#2631) Bridges subtree update (#2602) pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388) [ci] Move rust-features.sh script to .gitlab folder (#2630) Bump parity-db from 0.4.10 to 0.4.12 (#2635) sp-core: Rename VrfOutput to VrfPreOutput (#2534) chore: fix typo (#2596) Bump tracing-core from 0.1.31 to 0.1.32 (#2618) chore: fixed std wasm build of xcm (#2535) Fix PRdoc that have been previously drafted with older schema (#2623) Github Workflow migrations (#1574) Bridges update subtree (#2625) PVF: Add Secure Validator Mode (#2486) statement-distribution: Add tests for incoming acknowledgements (#2498) ...
ordian
added a commit
that referenced
this pull request
Dec 15, 2023
* tsv-disabling: (155 commits) Fix failing rc-automation GHA (#2648) [ci] Return CI_IMAGE variable (#2647) Support querying peer reputation (#2392) [ci] Update rust to 1.74 (#2545) Relax approval requirements on CI files (#2564) Added AllSiblingSystemParachains matcher to be used at a parachain level (#2422) Improve polkadot sdk docs (#2631) Bridges subtree update (#2602) pallet-xcm: add new flexible `transfer_assets()` call/extrinsic (#2388) [ci] Move rust-features.sh script to .gitlab folder (#2630) Bump parity-db from 0.4.10 to 0.4.12 (#2635) sp-core: Rename VrfOutput to VrfPreOutput (#2534) chore: fix typo (#2596) Bump tracing-core from 0.1.31 to 0.1.32 (#2618) chore: fixed std wasm build of xcm (#2535) Fix PRdoc that have been previously drafted with older schema (#2623) Github Workflow migrations (#1574) Bridges update subtree (#2625) PVF: Add Secure Validator Mode (#2486) statement-distribution: Add tests for incoming acknowledgements (#2498) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes paritytech/polkadot-sdk-docs#69