Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Test benchmarking v2 #3585

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Contracts: Test benchmarking v2 #3585

merged 11 commits into from
Mar 19, 2024

Conversation

pgherveou
Copy link
Contributor

No description provided.

@pgherveou pgherveou requested a review from athei as a code owner March 5, 2024 20:22
@pgherveou pgherveou changed the title Test benchmarking v2 Contracts: Test benchmarking v2 Mar 5, 2024
@pgherveou
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Mar 5, 2024

Here's a link to docs

@pgherveou
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 5, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-0446b041-b1a8-4f4b-a230-4d824b7329bb to cancel this command or bot cancel to cancel all commands in this pull request.

@pgherveou pgherveou added the R0-silent Changes should not be mentioned in any release notes label Mar 5, 2024
@command-bot
Copy link

command-bot bot commented Mar 5, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5445625/artifacts/download.

athei
athei reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

substrate/frame/contracts/src/benchmarking/mod.rs Outdated Show resolved Hide resolved
@pgherveou
Copy link
Contributor Author

Depends on #3574

@pgherveou pgherveou mentioned this pull request Mar 7, 2024
Merged
@pgherveou
Copy link
Contributor Author

pgherveou commented Mar 7, 2024 •
edited
Loading

🔒 for now some of the generated pov are much larger
@ggwpez is working on adding pov_mode = measured

https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=10&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=master&new=pg%2Fcontracts-benchmark-v2

waiting for #3616

@pgherveou pgherveou changed the base branch from master to oty-bench-v2-pov-mode March 8, 2024 17:20
@pgherveou pgherveou requested a review from a team as a code owner March 8, 2024 17:21
@pgherveou pgherveou changed the base branch from oty-bench-v2-pov-mode to master March 8, 2024 17:27
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5476947

@pgherveou
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 8, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-e6ea78a8-dda6-4eac-91d8-5750dc7f822a to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
fe5c722 
…=dev --target_dir=substrate --pallet=pallet_contracts
@command-bot
Copy link

command-bot bot commented Mar 8, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5478214/artifacts/download.

@pgherveou
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 19, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-d361e1ec-da03-43f0-81aa-21302df10bfa to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
9b3c4a3 
…=dev --target_dir=substrate --pallet=pallet_contracts
@command-bot
Copy link

command-bot bot commented Mar 19, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5570268/artifacts/download.

@pgherveou
Copy link
Contributor Author

bot bench substrate-pallet --pallet=pallet_contracts

@command-bot
Copy link

command-bot bot commented Mar 19, 2024 •
edited
Loading

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-9aa4ef8e-609e-4ba7-abf4-404d656e148a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 19, 2024

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5573329/artifacts/download.

@pgherveou pgherveou added this pull request to the merge queue Mar 19, 2024
Merged via the queue into master with commit e659c4b Mar 19, 2024
130 of 133 checks passed
@pgherveou pgherveou deleted the pg/contracts-benchmark-v2 branch March 19, 2024 19:39
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Mar 24, 2024
@pgherveou @dharjeezy
Contracts: Test benchmarking v2 (paritytech#3585)
ccaac29 
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xermicus xermicus xermicus approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgherveou @paritytech-cicd-pr @athei @xermicus