Benchmarking: Add pov_mode to V2 syntax #3616

ggwpez · 2024-03-07T20:57:13Z

Changes:

Port the pov_mode attribute from the V1 syntax to V2
Update pallet-whitelist and frame-benchmarking-pallet-pov

Follow up: also allow this attribute on top-level benchmark modules.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2024-03-07T20:57:43Z

bot bench substrate-pallet --pallet=frame_benchmarking_pallet_pov

command-bot · 2024-03-07T20:57:48Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5469399 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=frame_benchmarking_pallet_pov. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-36ec3a2f-a95d-48e4-adda-4d6d29efbbba to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-07T21:34:24Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=frame_benchmarking_pallet_pov has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5469399 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5469399/artifacts/download.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2024-03-08T15:51:41Z

bot bench substrate-pallet --pallet=pallet_whitelist

command-bot · 2024-03-08T15:51:47Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5475514 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_whitelist. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-d881c0fb-7fc8-40fc-b8f8-b690dd651376 to cancel this command or bot cancel to cancel all commands in this pull request.

…nto HEAD

pgherveou · 2024-03-08T16:01:32Z

substrate/frame/support/procedural/src/benchmark.rs

+#[derive(Debug, Clone)]
+struct PovModeAttr {


nit I would move the definition before the impl, I find it easier to scroll through the file this way

pgherveou · 2024-03-08T16:14:43Z

substrate/frame/support/procedural/src/benchmark.rs

+		let _ = || -> Result<()> {
+			let content;
+			syn::braced!(content in input);
+			maybe_content = Some(content);
+			Ok(())
+		}();


why do you need to return a Result here?

The syn::braced! macro just does a return 🙈
Its internally using parse_braces, but that is private IIUC.

…=dev --target_dir=substrate --pallet=pallet_whitelist

command-bot · 2024-03-08T16:24:23Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_whitelist has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5475514 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5475514/artifacts/download.

gupnik

Could we add some UI tests?

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez · 2024-03-15T14:25:54Z

bot update-ui

command-bot · 2024-03-15T14:26:00Z

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5547896 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-a19d11a6-b477-4c6b-8176-40f6a82f7550 to cancel this command or bot cancel to cancel all commands in this pull request.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

command-bot · 2024-03-15T14:37:47Z

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5547896 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5547896/artifacts/download.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Changes: - Port the `pov_mode` attribute from the V1 syntax to V2 - Update `pallet-whitelist` and `frame-benchmarking-pallet-pov` Follow up: also allow this attribute on top-level benchmark modules. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: command-bot <>

Benchmarking: Add pov_mode to V2 syntax

f6123b8

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update weights

35802e2

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez added T1-FRAME This PR/Issue is related to core FRAME, the framework. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Mar 8, 2024

ggwpez added 5 commits March 8, 2024 16:26

Cleanup

aab2929

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Put apache header

2869db4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Cleanup

546bc22

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Cleanup

ba9f211

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update whitelisted pallet

d01a711

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as ready for review March 8, 2024 15:51

ggwpez requested a review from a team as a code owner March 8, 2024 15:51

Merge branch 'master' of https://github.com/paritytech/polkadot-sdk i…

50c287b

…nto HEAD

pgherveou approved these changes Mar 8, 2024

View reviewed changes

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…

8bf6ecf

…=dev --target_dir=substrate --pallet=pallet_whitelist

pgherveou mentioned this pull request Mar 8, 2024

Contracts: Test benchmarking v2 #3585

Merged

gupnik self-requested a review March 12, 2024 14:04

gupnik approved these changes Mar 13, 2024

View reviewed changes

ggwpez added 2 commits March 14, 2024 16:36

Add UI tests

2d708b6

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge remote-tracking branch 'origin/master' into oty-bench-v2-pov-mode

de44a2f

ggwpez self-assigned this Mar 15, 2024

Add prdoc

6b36bb8

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update UI

10dc1b3

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez added this pull request to the merge queue Mar 19, 2024

Merged via the queue into master with commit abd3f0c Mar 19, 2024
131 of 132 checks passed

ggwpez deleted the oty-bench-v2-pov-mode branch March 19, 2024 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Benchmarking: Add pov_mode to V2 syntax #3616

Benchmarking: Add pov_mode to V2 syntax #3616

ggwpez commented Mar 7, 2024 •

edited

Loading

ggwpez commented Mar 7, 2024

command-bot bot commented Mar 7, 2024 •

edited

Loading

command-bot bot commented Mar 7, 2024

ggwpez commented Mar 8, 2024

command-bot bot commented Mar 8, 2024 •

edited

Loading

pgherveou Mar 8, 2024

pgherveou Mar 8, 2024

ggwpez Mar 8, 2024

command-bot bot commented Mar 8, 2024

gupnik left a comment

ggwpez commented Mar 15, 2024

command-bot bot commented Mar 15, 2024 •

edited

Loading

command-bot bot commented Mar 15, 2024

		#[derive(Debug, Clone)]
		struct PovModeAttr {

Benchmarking: Add pov_mode to V2 syntax #3616

Benchmarking: Add pov_mode to V2 syntax #3616

Conversation

ggwpez commented Mar 7, 2024 • edited Loading

ggwpez commented Mar 7, 2024

command-bot bot commented Mar 7, 2024 • edited Loading

command-bot bot commented Mar 7, 2024

ggwpez commented Mar 8, 2024

command-bot bot commented Mar 8, 2024 • edited Loading

pgherveou Mar 8, 2024

Choose a reason for hiding this comment

pgherveou Mar 8, 2024

Choose a reason for hiding this comment

ggwpez Mar 8, 2024

Choose a reason for hiding this comment

command-bot bot commented Mar 8, 2024

gupnik left a comment

Choose a reason for hiding this comment

ggwpez commented Mar 15, 2024

command-bot bot commented Mar 15, 2024 • edited Loading

command-bot bot commented Mar 15, 2024

ggwpez commented Mar 7, 2024 •

edited

Loading

command-bot bot commented Mar 7, 2024 •

edited

Loading

command-bot bot commented Mar 8, 2024 •

edited

Loading

command-bot bot commented Mar 15, 2024 •

edited

Loading