[subsystem-benchmarks] Fix availability-write regression tests #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
added
R0-silent
alvicsam
approved these changes
Mar 14, 2024
AndreiEres
changed the title
sandreim
reviewed
Mar 18, 2024
...t/node/network/availability-distribution/tests/availability-distribution-regression-bench.rs
Outdated
Show resolved
Hide resolved
...t/node/network/availability-distribution/tests/availability-distribution-regression-bench.rs
Outdated
Show resolved
Hide resolved
sandreim
reviewed
Mar 21, 2024
AndreiEres
changed the title
sandreim
approved these changes
Mar 22, 2024
| messages.extend(usage.check_network_usage(&[ | ||
| ("Received from peers", 307200.000, 0.05), | ||
| ("Sent to peers", 1.667, 0.05), | ||
| // We don't expect any other values for received and sent |
There was a problem hiding this comment.
I would rephrase it as no variance is expected here, also, why not 0.0 ?
There was a problem hiding this comment.
Set it to 0.001 because we operate with floats
|
The CI pipeline was cancelled due to failure one of the required jobs. |
AndreiEres
changed the title
|
After this was merged, the CI now fails on TOML format of |
This was referenced Mar 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Fixes formatting for #3698
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ytech#3698) Adds availability-write regression tests. The results for the `availability-distribution` subsystem are volatile, so I had to reduce the precision of the test.
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
Fixes formatting for paritytech#3698
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds availability-write regression tests.
The results for the
availability-distributionsubsystem are volatile, so I had to reduce the precision of the test.