[After Transaction Extension PR] CheckMetadataHash transaction extension benchmark. #5277
Conversation
| let high = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2]); | ||
| let low = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2 + 1]); | ||
|
|
||
| let (Some(high), Some(low)) = (high, low) else { return None }; |
There was a problem hiding this comment.
| let high = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2]); | |
| let low = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2 + 1]); | |
| let (Some(high), Some(low)) = (high, low) else { return None }; | |
| let high = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2])?; | |
| let low = from_hex_digit_panic(hex_str.as_bytes()[start + i * 2 + 1])?; |
There was a problem hiding this comment.
? not allowed in const fn
|
|
||
| /// Function to convert hex string to Option<[u8; 32]> in a const context. | ||
| /// Returns `None` if fails to decode. | ||
| pub const fn hex_str_to_32_bytes(hex_str: &str) -> Option<[u8; HASH_LEN]> { |
There was a problem hiding this comment.
I discovered const-hex, it seems popular. I will switch to it.
Co-authored-by: Bastian Köcher <git@kchr.de>
Cargo.toml
Outdated
| @@ -668,6 +668,7 @@ codec = { version = "3.6.12", default-features = false, package = "parity-scale- | |||
| collectives-westend-emulated-chain = { path = "cumulus/parachains/integration-tests/emulated/chains/parachains/collectives/collectives-westend" } | |||
| collectives-westend-runtime = { path = "cumulus/parachains/runtimes/collectives/collectives-westend" } | |||
| color-eyre = { version = "0.6.1", default-features = false } | |||
| const-hex = { version = "1.10.0", default-features = false } | |||
There was a problem hiding this comment.
This is not a new dependency because some of our dependency already depend on it.
I picked up the version already used by some dependencies in the Cargo.lock
| const RUNTIME_METADATA: Option<[u8; 32]> = if let Some(hex) = option_env!("RUNTIME_METADATA_HASH") { | ||
| match const_hex::const_decode_to_array(hex.as_bytes()) { | ||
| Ok(hex) => Some(hex), | ||
| Err(_) => None, |
There was a problem hiding this comment.
I cannot find a way to print some error in const fn, but this behavior is unchanged.
There was a problem hiding this comment.
You can panic in const? That should be good enough here?
There was a problem hiding this comment.
Yes, done in 8ffd8a9
Note that I can't put the exact error in the panic because it only accepts a string literal.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
…gui-check-metadata-hash-benchmarks
gui1117
changed the title
After #3685
The transaction extensions cost is:
array_bytes::hex2array_uncheckedto convert a hexadecimal string into a 32 bytes array.So I feel introducing a new pallet to have it benchmarked is overkill.
In this PR:
array_bytes::hex2array_uncheckedcall and changed to a const implementation.Alternative 1:
Alternative 2:
cc @georgepisaltu