-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[After Transaction Extension PR] CheckMetadataHash transaction extension benchmark. #5277
Draft
gui1117
wants to merge
13
commits into
paritytech:george/restore-gav-tx-ext
Choose a base branch
from
gui1117:gui-check-metadata-hash-benchmarks
base: george/restore-gav-tx-ext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−3
Draft
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
25350a5
Make hex2array static and checked at compile time
gui1117 8144c61
no breaking change
gui1117 edffdaf
fix naming
gui1117 20a74ea
use const for 32
gui1117 eea48de
Update substrate/frame/metadata-hash-extension/src/lib.rs
gui1117 19923a1
use const-hex
gui1117 456d683
fmt
gui1117 6d40a23
Merge branch 'george/restore-gav-tx-ext' into gui-check-metadata-hash…
gui1117 8ffd8a9
panic on invalid environment variable
gui1117 7bd871e
fix example
gui1117 5301304
Merge branch 'george/restore-gav-tx-ext' into gui-check-metadata-hash…
gui1117 4050200
Merge remote-tracking branch 'origin/george/restore-gav-tx-ext' into …
gui1117 6d94fa4
prdoc
gui1117 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find a way to print some error in const fn, but this behavior is unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can panic in const? That should be good enough here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, done in 8ffd8a9
Note that I can't put the exact error in the panic because it only accepts a string literal.