Refactor pallet-proxy to use v2 benchmarks #6211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggwpez Could you add R0 label? We have many similar pallet to refactor v2, and their prdocs are similar. |
programskillforverification
changed the title
|
@ggwpez pls review |
gui1117
approved these changes
Oct 26, 2024
rockbmb
approved these changes
Oct 26, 2024
44 tasks
seadanda
approved these changes
Oct 29, 2024
|
@programskillforverification why was this closed? |
#5995 has done the same thing with this pr |
|
Ah, I am sorry about that. your work here though is good, so if you would like to receive a small tip in DOT we can still do that for you. |
Thanks a lot. I am uncomfortable to receive tip due to not merge. I will pick new pallet and continue to contribute. |
|
@programskillforverification okay! thank you for your continuing contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the pallet-proxy to the v2 of frame_benchmarking.
Integration
N/A