Refactor pallets to V2 bench syntax #6202

ggwpez · 2024-10-23T17:01:14Z

We should move all remaining pallets to the V2 benchmarking syntax. It seems to be stable and feature complete.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on. Please pick only one or a small set of pallets - not all at once. This keeps review times low.

Full pallet list:

Then the Polkadot and Cumulus pallets:

The text was updated successfully, but these errors were encountered:

AurevoirXavier · 2024-10-28T05:20:17Z

Some updates:

babe, fast-unstake Migrate some pallets to benchmark v2 #6311
child-bounties Migrate pallet-child-bounties benchmark to v2 #6310
claims Refactor pallet claims #6318
elections-phragmen Migrate pallet-elections-phragmen benchmark to v2 and improve doc #6314
election-provider-multi-phase Migrate pallet-election-provider-multi-phase benchmark to v2 and improve doc #6316
election-provider-support-benchmarking Migrate pallet-election-provider-support-benchmarking benchmark to v2 #6315
glutton Migrate pallet-glutton benchmark to v2 #6296
im-online Migrate pallet-im-online benchmark to v2 #6295
inclusion Migrate inclusion benchmark to v2 #6368
multisig, proxy Use frame umbrella crate in pallet-proxy and pallet-multisig #5995
nis Migrate pallet-nis benchmark to v2 #6293
nft-fractionalization migrate pallet-nft-fractionalization to benchmarking v2 syntax #6301
nomination-pool migrate pallet-nomination-pool-benchmarking to benchmarking syntax v2 #6302
preimage Migrate pallet-preimage to benchmark v2 #6277
offences migrate pallet-offences-benchmarking to benchmark v2 syntax #6300
recovery migrate pallet-recovery to benchmark V2 syntax #6299
remark migrate pallet-remarks to v2 bench syntax #6291
scheduler Migrate pallet-scheduler benchmark to v2 #6292
session migrate pallet-session-benchmarking to bench V2 syntax #6294
society Refactor pallet society #6367
timestamp Migrate pallet-timestamp benchmark to v2 #6258
transaction-storage, indices Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290
utility Migrate pallet-utility to benchmark v2 #6276
vesting Migrate pallet-vesting benchmark to v2 #6254

Part of: - #6202.

Part of: - #6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

Part of: - paritytech#6202.

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

Part of: - paritytech#6202.

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

programskillforverification · 2024-10-30T13:19:51Z

Pick up:

transaction-storage, indices Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290
babe, child-bounties, fast-unstake Migrate some pallets to benchmark v2 #6311
democracy

Part of: - #6202. --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

clangenb · 2024-10-30T13:55:51Z

Pickup:

pallet-remark, done: migrate pallet-remarks to v2 bench syntax #6291
~~pallet-scheduler~~

AurevoirXavier · 2024-10-30T13:59:57Z

Pickup:

pallet-remark, pallet-scheduler

Hi, I'm working scheduler currently. :)

clangenb · 2024-10-30T14:00:24Z

Thanks for the quick response 🚀

clangenb · 2024-10-30T14:23:36Z

Pickup:

pallet-sessions, done: migrate pallet-session-benchmarking to bench V2 syntax #6294
pallet-recovery, done: migrate pallet-recovery to benchmark V2 syntax #6299
pallet-offences, done: migrate pallet-offences-benchmarking to benchmark v2 syntax #6300

AurevoirXavier · 2024-10-30T14:50:41Z

Pick up:

transaction-storage, indices

babe, child-bounties, democracy

fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

- [x] Removing `without_storage_info` and adding bounds on the stored types for pallet `claims` - issue #6289 - [x] Migrating to benchmarking V2 - #6202 --------- Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: Dónal Murray <donal.murray@parity.io>

…ove doc (#6316) Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Part of: * #6202 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Part of: * #6202 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

re-gius · 2024-11-05T12:10:08Z

Working on pallet-society in #6367

Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

clangenb · 2024-11-06T13:58:00Z

Pickup:

pallet-fast-unstake: migrate pallet-fast-unstake to bench v2 syntax #6390

Edit: Sorry I haven't seen that you were on fast-unstake: @programskillforverification. Feel free to incorporate my PRs changes into your branch, mine would be finished, and I don't want to snatch work from you.

clangenb · 2024-11-06T14:40:05Z

Pickup:

./polkadot/xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs, done: Migrate pallet-xcm-benchmarks/generic to benchmarking v2 syntax #6395

…#6315) Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>

) Part of: - #6202. --------- Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: GitHub Action <action@github.com>

…#6290) Part of: #6202 --------- Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: GitHub Action <action@github.com>

Migrates pallet-nft-fractionalization to benchmarking v2 syntax. Part of: * #6202 --------- Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Bastian Köcher <git@kchr.de>

Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

- [x] Removing `without_storage_info` and adding bounds on the stored types for pallet `society` - issue #6289 - [x] Migrating to benchmarking V2 - #6202 --------- Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com> Co-authored-by: Muharem <ismailov.m.h@gmail.com>

kianenigma · 2024-11-15T07:40:41Z

Great work being done around all PRs made here. Thank you to all contributors, and thank you @re-gius for coordinating.

All of these PRs can be merged with Silent tag as they are backwards compat.
@re-gius please reward those who work on this and provide a DOT address with a /tip small.

re-gius · 2024-11-15T14:07:28Z

@re-gius please reward those who work on this and provide a DOT address with a /tip small.

I'm checking all the merged PRs and rewarding with /tip small one in two for each user (as @shawntabrizi started doing).

clangenb · 2024-11-15T14:40:29Z

Pickup:

./polkadot/xcm/pallet-xcm/src/benchmarking.rs, done Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501

…#6302) Migrates pallet-nomination-pool-benchmarking to benchmarking syntax v2. Part of: * #6202 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

ndkazu · 2024-11-16T14:39:29Z

Hello,
I am working on pallet-democracy migration to benchmarks V2 in the following PR:
#6509

Part of #6202 --------- Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

Krayt78 · 2024-11-19T17:36:19Z

Hi !
I started working on pallet-offences-benchmark migration to V2 in this draft PR #6543

# Description Migrates pallet-democracy benchmarks to benchmark v2 syntax This is Part of #6202 --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: command-bot <> Co-authored-by: Dmitry Markin <dmitry@markin.tech> Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

ggwpez added this to Runtime / FRAME Oct 23, 2024

github-project-automation bot moved this to Backlog in Runtime / FRAME Oct 23, 2024

ggwpez changed the title ~~Migrate all pallets to benchmarking V2 syntax~~ Refactor pallets to V2 bench syntax Oct 23, 2024

ggwpez mentioned this issue Oct 23, 2024

undetected unused variables in frame benchmarking V1 #6078

Open

This was referenced Oct 28, 2024

Migrate pallet-vesting benchmark to v2 #6254

Merged

Migrate pallet-timestamp benchmark to v2 #6258

Merged

github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (#6254)

1497635

Part of: - #6202.

github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (#6258)

80cd5fd

Part of: - #6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

This was referenced Oct 29, 2024

Migrate pallet-utility to benchmark v2 #6276

Merged

Migrate pallet-preimage to benchmark v2 #6277

Open

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (paritytech#6254)

1819d89

Part of: - paritytech#6202.

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (paritytech#6258)

dee9777

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-vesting benchmark to v2 (paritytech#6254)

65ee481

Part of: - paritytech#6202.

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024

Migrate pallet-timestamp benchmark to v2 (paritytech#6258)

b41419a

Part of: - paritytech#6202 --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024

Migrate pallet-utility to benchmark v2 (#6276)

06debd0

Part of: - #6202. --------- Co-authored-by: Dónal Murray <donalm@seadanda.dev>

programskillforverification mentioned this issue Oct 30, 2024

Migrate pallet-transaction-storage and pallet-indices to benchmark v2 #6290

Merged

clangenb mentioned this issue Oct 30, 2024

migrate pallet-remarks to v2 bench syntax #6291

Merged

This was referenced Oct 30, 2024

Migrate pallet-scheduler benchmark to v2 #6292

Open

Migrate pallet-nis benchmark to v2 #6293

Open

github-merge-queue bot pushed a commit that referenced this issue Nov 4, 2024

migrate pallet-recovery to benchmark V2 syntax (#6299)

b1084e7

Part of: * #6202 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

re-gius mentioned this issue Nov 5, 2024

Refactor pallet society #6367

Merged

2 tasks

github-merge-queue bot pushed a commit that referenced this issue Nov 5, 2024

Migrate pallet-im-online benchmark to v2 (#6295)

8b6c6eb

Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

clangenb mentioned this issue Nov 6, 2024

migrate pallet-fast-unstake to bench v2 syntax #6390

Closed

clangenb mentioned this issue Nov 6, 2024

Migrate pallet-xcm-benchmarks/generic to benchmarking v2 syntax #6395

Open

github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024

Migrate pallet-elections-phragmen benchmark to v2 and improve doc (#6314

c4e94d3

) Part of: - #6202. --------- Co-authored-by: Giuseppe Re <giuseppe.re@parity.io> Co-authored-by: GitHub Action <action@github.com>

dharjeezy mentioned this issue Nov 9, 2024

pallet democracy benchmark v2 #6421

Open

github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024

Migrate pallet-child-bounties benchmark to v2 (#6310)

b570baf

Part of: - #6202. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

clangenb mentioned this issue Nov 15, 2024

Migrate pallet-xcm benchmarks to benchmark v2 syntax #6501

Open

ndkazu mentioned this issue Nov 16, 2024

Migrate pallet-democracy benchmarks to benchmark v2 syntax #6509

Merged

github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024

Migrate some pallets to benchmark v2 (#6311)

603a392

Part of #6202 --------- Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>

Krayt78 mentioned this issue Nov 19, 2024

migrate-pallet-offences-benchmarking-to-benchmarking-syntax-v2 #6543

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor pallets to V2 bench syntax #6202

Refactor pallets to V2 bench syntax #6202

ggwpez commented Oct 23, 2024 •

edited by re-gius

Loading

AurevoirXavier commented Oct 28, 2024 •

edited

Loading

programskillforverification commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading

AurevoirXavier commented Oct 30, 2024

clangenb commented Oct 30, 2024

clangenb commented Oct 30, 2024 •

edited

Loading

AurevoirXavier commented Oct 30, 2024

re-gius commented Nov 5, 2024

clangenb commented Nov 6, 2024 •

edited

Loading

clangenb commented Nov 6, 2024 •

edited

Loading

kianenigma commented Nov 15, 2024

re-gius commented Nov 15, 2024

clangenb commented Nov 15, 2024 •

edited

Loading

ndkazu commented Nov 16, 2024

Krayt78 commented Nov 19, 2024

Refactor pallets to V2 bench syntax #6202

Refactor pallets to V2 bench syntax #6202

Comments

ggwpez commented Oct 23, 2024 • edited by re-gius Loading

AurevoirXavier commented Oct 28, 2024 • edited Loading

programskillforverification commented Oct 30, 2024 • edited Loading

clangenb commented Oct 30, 2024 • edited Loading

AurevoirXavier commented Oct 30, 2024

clangenb commented Oct 30, 2024

clangenb commented Oct 30, 2024 • edited Loading

AurevoirXavier commented Oct 30, 2024

re-gius commented Nov 5, 2024

clangenb commented Nov 6, 2024 • edited Loading

clangenb commented Nov 6, 2024 • edited Loading

kianenigma commented Nov 15, 2024

re-gius commented Nov 15, 2024

clangenb commented Nov 15, 2024 • edited Loading

ndkazu commented Nov 16, 2024

Krayt78 commented Nov 19, 2024

ggwpez commented Oct 23, 2024 •

edited by re-gius

Loading

AurevoirXavier commented Oct 28, 2024 •

edited

Loading

programskillforverification commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading

clangenb commented Oct 30, 2024 •

edited

Loading

clangenb commented Nov 6, 2024 •

edited

Loading

clangenb commented Nov 6, 2024 •

edited

Loading

clangenb commented Nov 15, 2024 •

edited

Loading