Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-vesting benchmark to v2 #6254

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Migrate pallet-vesting benchmark to v2 #6254

merged 3 commits into from
Oct 29, 2024

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier commented Oct 28, 2024 •
edited
Loading

@AurevoirXavier AurevoirXavier requested review from a team and koute as code owners October 28, 2024 07:26
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 28, 2024
Open
44 tasks
@seadanda seadanda added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Oct 29, 2024
seadanda
seadanda reviewed Oct 29, 2024
View reviewed changes
substrate/primitives/panic-handler/src/lib.rs
@@ -30,7 +30,7 @@ use std::{
cell::Cell,
io::{self, Write},
marker::PhantomData,
panic::{self, PanicInfo},
panic::{self, PanicHookInfo},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change - why is this in the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clippy complain while running benchmark for this pallet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to move this to a single PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will temporarily revert this, as it causes issues with the CI.

@seadanda seadanda added the R0-silent Changes should not be mentioned in any release notes label Oct 29, 2024
@shawntabrizi shawntabrizi added this pull request to the merge queue Oct 29, 2024
@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@AurevoirXavier Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

Merged via the queue into paritytech:master with commit 1497635 Oct 29, 2024
194 of 196 checks passed
@AurevoirXavier AurevoirXavier deleted the x/benchmarkv2-vesting branch October 29, 2024 14:23
@AurevoirXavier
Copy link
Contributor Author

@AurevoirXavier Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

Added.

@shawntabrizi
Copy link
Member

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@shawntabrizi A referendum for a small (20 DOT) tip was successfully submitted for @AurevoirXavier (156HGo9setPcU2qhFMVWLkcmtCEGySLwNqa3DaEiYSWtte4Y on polkadot).

Referendum number: 1263.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
1819d89 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
65ee481 
Part of:

- paritytech#6202.
@skunert skunert mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockbmb rockbmb rockbmb approved these changes

@seadanda seadanda seadanda left review comments

@ggwpez ggwpez ggwpez left review comments

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AurevoirXavier @shawntabrizi @ggwpez @seadanda @rockbmb