Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-scheduler benchmark to v2 #6292

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Migrate pallet-scheduler benchmark to v2 #6292

wants to merge 5 commits into from
+202 −104

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier requested a review from a team as a code owner October 30, 2024 14:54
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 30, 2024
Open
44 tasks
re-gius
re-gius reviewed Nov 13, 2024
View reviewed changes
substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
AurevoirXavier and others added 2 commits November 19, 2024 10:30
@AurevoirXavier @re-gius
Update substrate/frame/scheduler/src/benchmarking.rs
42f9b31 
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
@AurevoirXavier @re-gius
Update substrate/frame/scheduler/src/benchmarking.rs
ed5d802 
Co-authored-by: Giuseppe Re <giuseppe.re@parity.io>
@AurevoirXavier
Update as suggested
71ec439 
Signed-off-by: Xavier Lau <x@acg.box>
@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. labels Nov 19, 2024
gui1117
gui1117 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The post assertions of those benchmarks are not nice, but it is not related to the PR.

substrate/frame/scheduler/src/benchmarking.rs Outdated Show resolved Hide resolved
substrate/frame/scheduler/src/benchmarking.rs
result = Pallet::<T>::execute_dispatch(&mut counter, origin, call);
}

assert!(result.is_ok());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewer, this has been added by the PR, but I guess it is fine.

substrate/frame/scheduler/src/benchmarking.rs
result = Pallet::<T>::execute_dispatch(&mut counter, origin, call);
}

assert!(result.is_ok());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewer, this has been added by the PR, but I guess it is fine.

@AurevoirXavier @gui1117
Update benchmarking.rs
a4373b8 
Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurevoirXavier @gui1117 @re-gius