migrate pallet-offences-benchmarking to benchmark v2 syntax #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
Oct 30, 2024
| ) -> Result<(Vec<IdentificationTuple<T>>, Vec<Offender<T>>), &'static str> { | ||
| ) -> Result<Vec<IdentificationTuple<T>>, &'static str> { |
There was a problem hiding this comment.
Offenders was unused, and it was a private function, so I removed it.
Comment on lines
+70
to
+71
| // corresponds to the opaque key id above | ||
| const KEY_TYPE_IDS: &'static [KeyTypeId] = &[KeyTypeId([100u8, 117u8, 109u8, 121u8])]; |
There was a problem hiding this comment.
Needed to fix genesis integrity check error.
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates pallet-offences-benchmarking to benchmark v2 syntax.
Part of: