Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for 'Simplify NativeExecutionDispatch and remove the native_executor_instance!' (9562) #3643

Merged
8 commits merged into from
Aug 16, 2021
Merged

Companion PR for 'Simplify NativeExecutionDispatch and remove the native_executor_instance!' (9562) #3643

8 commits merged into from
Aug 16, 2021

Conversation

expenses
Copy link
Contributor

@expenses expenses mentioned this pull request Aug 16, 2021
Merged
@expenses expenses added A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 16, 2021
kianenigma
kianenigma approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drahnr
drahnr approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Aug 16, 2021

Waiting for commit status.

HCastano
HCastano approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridges code looks fine 👍

@ghost ghost merged commit a79d094 into master Aug 16, 2021
@ghost ghost deleted the ashley-executor-companion branch August 16, 2021 15:44
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HCastano HCastano HCastano approved these changes

@kianenigma kianenigma kianenigma approved these changes

@gilescope gilescope gilescope approved these changes

@drahnr drahnr drahnr approved these changes

@bkchr bkchr Awaiting requested review from bkchr

@svyatonik svyatonik Awaiting requested review from svyatonik

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@expenses @drahnr @gilescope @kianenigma @HCastano