This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Simplify NativeExecutionDispatch and remove the native_executor_instance! macro
#9562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expenses
added
A0-please_review
expenses
changed the title
NativeExecutionDispatch and remove the native_executor_instance! macroNativeExecutionDispatch and remove the native_executor_instance! macro
expenses
changed the title
NativeExecutionDispatch and remove the native_executor_instance! macroNativeExecutionDispatch and remove the native_executor_instance! macro
gilescope
reviewed
Aug 13, 2021
| fn native_version() -> sc_executor::NativeVersion { | ||
| node_template_runtime::native_version() | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems a lot less magic to me. 👍
gilescope
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
LGTM. If we go ahead with this we should also update the examples - E.g.
https://github.com/substrate-developer-hub/recipes/blob/master/nodes/kitchen-node/src/service.rs
bkchr
approved these changes
Aug 13, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
JoshOrndorff
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Aug 24, 2021
JoshOrndorff
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Sep 16, 2021
JoshOrndorff
added a commit
to moonbeam-foundation/frontier
that referenced
this pull request
Sep 28, 2021
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot companion: paritytech/polkadot#3643
Part of the
sc-executorrefactor. As the previousNativeExecutionDispatch::dispatch(ext, method, data)function was only used once, it was be inlined.