Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix cumulus companion CI job #4451

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Fix cumulus companion CI job #4451

merged 4 commits into from
Dec 3, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Dec 2, 2021

@bkchr bkchr requested a review from a team as a code owner December 2, 2021 13:18
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 2, 2021
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Dec 2, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

https://github.com/paritytech/pipeline-scripts
- ./pipeline-scripts/check_dependent_project.sh
paritytech
polkadot
--polkadot
"$DEPENDENT_REPO"
"$GITHUB_PR_TOKEN"
$CARGO_UPDATE_CRATES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$CARGO_UPDATE_CRATES
"$CARGO_UPDATE_CRATES"

let's be consistent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's a space-separated list, better {} then

.gitlab-ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com>
@bkchr bkchr merged commit 09e3d79 into master Dec 3, 2021
@bkchr bkchr deleted the bkchr-cumulus-companion branch December 3, 2021 13:14
ordian added a commit that referenced this pull request Dec 3, 2021
* master: (23 commits)
  Fix path of the polkadot_injected docker image (#4463)
  update docs on `validation_upgrade_frequency` (#4460)
  Fix path of the polkadot sha256 (#4458)
  Fix cumulus companion CI job (#4451)
  Add doc about runtime version bump (#4418)
  Bump trybuild from 1.0.52 to 1.0.53 (#4455)
  companion for #10231 (#4306)
  trivial fix (#4441)
  Rococo: ability to programatically assign slots to teams (#3943)
  Add parent header hash to log (#4421)
  bump tx versions (#4447)
  Companion for substrate/10347 (#4413)
  Improve paras runtime `BenchBuilder` api (#4318)
  Add CI team to `CODEOWNERS` file (#4350)
  XCM Benchmarks for Generic Instructions (#3940)
  Announce only on releases (#4417)
  Companion for  10379 (EnsureOneOf) (#4405)
  add pallet-babe/std (#4438)
  update Cargo.lock
  Squashed 'bridges/' changes from 407bf44a8a..1602249f0a
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants