This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
added
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
labels
Dec 2, 2021
gui1117
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good to me
TriplEight
previously requested changes
Dec 3, 2021
https://github.com/paritytech/pipeline-scripts | ||
- ./pipeline-scripts/check_dependent_project.sh | ||
paritytech | ||
polkadot | ||
--polkadot | ||
"$DEPENDENT_REPO" | ||
"$GITHUB_PR_TOKEN" | ||
$CARGO_UPDATE_CRATES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
$CARGO_UPDATE_CRATES | |
"$CARGO_UPDATE_CRATES" |
let's be consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah that's a space-separated list, better {}
then
Co-authored-by: Denis Pisarev <17856421+TriplEight@users.noreply.github.com>
TriplEight
approved these changes
Dec 3, 2021
ordian
added a commit
that referenced
this pull request
Dec 3, 2021
* master: (23 commits) Fix path of the polkadot_injected docker image (#4463) update docs on `validation_upgrade_frequency` (#4460) Fix path of the polkadot sha256 (#4458) Fix cumulus companion CI job (#4451) Add doc about runtime version bump (#4418) Bump trybuild from 1.0.52 to 1.0.53 (#4455) companion for #10231 (#4306) trivial fix (#4441) Rococo: ability to programatically assign slots to teams (#3943) Add parent header hash to log (#4421) bump tx versions (#4447) Companion for substrate/10347 (#4413) Improve paras runtime `BenchBuilder` api (#4318) Add CI team to `CODEOWNERS` file (#4350) XCM Benchmarks for Generic Instructions (#3940) Announce only on releases (#4417) Companion for 10379 (EnsureOneOf) (#4405) add pallet-babe/std (#4438) update Cargo.lock Squashed 'bridges/' changes from 407bf44a8a..1602249f0a ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is here paritytech/pipeline-scripts#12