Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix cumulus companion CI job #4451

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Fix cumulus companion CI job #4451

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a5eb6f
Fix cumulus companion CI job
bkchr Dec 2, 2021
cb8e7e4
Pass by env variable
bkchr Dec 2, 2021
4c3ec43
Switch to the latest release
bkchr Dec 3, 2021
2b687a3
Update .gitlab-ci.yml
bkchr Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ variables:
VAULT_SERVER_URL: "https://vault.parity-mgmt-vault.parity.io"
VAULT_AUTH_PATH: "gitlab-parity-io-jwt"
VAULT_AUTH_ROLE: "cicd_gitlab_parity_${CI_PROJECT_NAME}"
PIPELINE_SCRIPTS_TAG: "v0.1"
PIPELINE_SCRIPTS_TAG: "v0.4"

default:
cache: {}
Expand Down Expand Up @@ -292,19 +292,21 @@ build-malus:
script:
- git clone
--depth=1
"--branch=$PIPELINE_SCRIPTS_TAG"
"--branch=bkchr-update-cargo"
bkchr marked this conversation as resolved.
Show resolved Hide resolved
https://github.com/paritytech/pipeline-scripts
- ./pipeline-scripts/check_dependent_project.sh
paritytech
polkadot
--polkadot
"$DEPENDENT_REPO"
"$GITHUB_PR_TOKEN"
$CARGO_UPDATE_CRATES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$CARGO_UPDATE_CRATES
"$CARGO_UPDATE_CRATES"

let's be consistent

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the script.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's a space-separated list, better {} then


check-dependent-cumulus:
<<: *check-dependent-project
variables:
DEPENDENT_REPO: cumulus
CARGO_UPDATE_CRATES: "sp-io polkadot-runtime-common"

check-transaction-versions:
stage: build
Expand Down