Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release to crates-io #36

Closed
ggwpez opened this issue Jul 23, 2024 · 4 comments · Fixed by #40
Closed

Release to crates-io #36

ggwpez opened this issue Jul 23, 2024 · 4 comments · Fixed by #40
Assignees
@mutantcornholio

Comments

@ggwpez
Copy link
Member

ggwpez commented Jul 23, 2024

0.0.8 has not made it here yet: https://crates.io/crates/prdoc
@mutantcornholio mutantcornholio self-assigned this Aug 13, 2024
@mutantcornholio
Copy link
Contributor

Turns out that @chevdor still owns prdoc and prdoclib at crates.io when I asked about it in DM, he refused to add parity account to owners:

I did consider the options for the prdoc publishing on crates.io and I think it would be best for parity to publish to a parity crate such as some parity-prdoc for instance.
I am not "in line" with some of the recent changes to the source and I want to keep prdoc a generic tool as it was originally designed.
That will also give you/parity more freedom about regarding the next version and its features

I guess, we'll have to publish it as parity-prdoc / parity-prdoclib

@mutantcornholio
Copy link
Contributor

Do we actually need a separate crate for prdoclib? Why not provide both bin and lib from the same crate?

@ggwpez
Copy link
Member Author

ggwpez commented Aug 30, 2024

Yea, then we should possibly also rename the repo to parity-prdoc to reflect this.

@mutantcornholio mutantcornholio mentioned this issue Sep 2, 2024
Merged
@mutantcornholio
Copy link
Contributor

https://crates.io/crates/parity-prdoc

@ggwpez ggwpez mentioned this issue Sep 6, 2024
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this issue Sep 9, 2024
@ggwpez
Install prdoc from Parity fork (#5625)
d2e962f 
Prdoc is now published as a Parity fork under the
[`parity-prdoc`](https://crates.io/crates/parity-prdoc) crate after the
directions diverged from the ideas of the original creator (discussions
[here](paritytech/prdoc#40) and
[here](paritytech/prdoc#36)).
Now updating the install instructions here.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mutantcornholio mutantcornholio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renamed and merged crates paritytech/prdoc
2 participants
@mutantcornholio @ggwpez