Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed and merged crates #40

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Renamed and merged crates #40

merged 1 commit into from
Sep 2, 2024

Conversation

mutantcornholio
Copy link
Contributor

@mutantcornholio mutantcornholio commented Aug 30, 2024 •
edited
Loading

@chevdor still owns the package on crates.io, and refuses to allow parity to publish it

And maybe instead of two crates, we only need one?

WDYT?

Fixes #36

@ggwpez
Copy link
Member

ggwpez commented Aug 30, 2024

Release engineering can also publish it: https://crates.io/crates/prdoc

@mutantcornholio
Copy link
Contributor Author

However, we can't use Parity's user to publish it.
As far as I understood it, I'd have to ask @Morganamilo or @EgorPopelyaev for their crates.io token to keep publishing it.
Just as well as Will can revoke the access at any time (which seems probable, as he refuses to cooperate), and we can't do anything about it.

@ggwpez
Copy link
Member

ggwpez commented Aug 30, 2024 •
edited
Loading

I spoke to Will and confirmed that it is okay to remove Rel-Eng as publisher and that Parity should fork.
Then please go ahead with renaming the crate and setting up the publish pipeline again with the new name: parity-prdoc.
Maybe we also rename the repo here, not sure.

PS: We could keep the binary name backwards compatible, so that it installs two binaries: prdoc and parity-prdoc. Then it would not break workflows.

@mutantcornholio
Copy link
Contributor Author

PS: We could keep the binary name backwards compatible, so that it installs two binaries: prdoc and parity-prdoc. Then it would not break workflows.

Why not just keep producing a single prdoc binary?
Two identical binaries seems a bit weird and excessive.

Maybe we also rename the repo here, not sure.

I think maybe just mention it in README and that's all? paritytech/prdoc still has "parity" in the name.

@mutantcornholio mutantcornholio force-pushed the yuri/rename-packages branch 2 times, most recently from d5a50fa to c80cf7b Compare September 2, 2024 07:16
@mutantcornholio
Renamed and merged crates
22da38e 
@chevdor still owns the package on crates.io, and refuses to allow
parity to publish it

And maybe instead of two crates, we only need one?
@mutantcornholio mutantcornholio merged commit cb9a6b7 into master Sep 2, 2024
3 checks passed
@mutantcornholio mutantcornholio deleted the yuri/rename-packages branch September 2, 2024 07:28
@ggwpez ggwpez mentioned this pull request Sep 6, 2024
Merged
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Sep 9, 2024
@ggwpez
Install prdoc from Parity fork (#5625)
d2e962f 
Prdoc is now published as a Parity fork under the
[`parity-prdoc`](https://crates.io/crates/parity-prdoc) crate after the
directions diverged from the ideas of the original creator (discussions
[here](paritytech/prdoc#40) and
[here](paritytech/prdoc#36)).
Now updating the install instructions here.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@Morganamilo Morganamilo Awaiting requested review from Morganamilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release to crates-io
2 participants
@mutantcornholio @ggwpez