-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Experimental PLO endpoints #509
Conversation
* add crowdloan routes to the ParasController * add crowdloan routes functionality in the ParaService * fix: remove parseFundInfo, cleanup types * cleanup comments * fix type * add types for crowdloans route * cleanup service and controller * remove todo * fix: types for paraId, fix fundInfo query param, optimize entries
* Update auctions current to use offset to key into Winning * MVP leases current * Add paras service * Add /paras to controller * Update doc comments * Add retirement end * Add response interfaces * Add interfaces for leases, para, and auctions * Add doc comment to interface * Exclude lease-info for indexs with no lease * Remove retirement period end bc no longer have retirements * Address tarik review comment * Apply suggestions from code review Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com> Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
…ritytech/substrate-api-sidecar into feat-experiment-plo-endpoints
* feat: include lease set for each winning bid in auctions/current * Rename some vars * Update comment
Some of the hardcoded values for when we enumerate lease periods will need to be updated to reflect github.com/paritytech/polkadot/pull/2862 Ideally we can pull the slot range dynamically |
feat: add testing for plo endpoints (#512) Co-authored-by: Zeke Mostov <32168567+emostov@users.noreply.github.com>
…ritytech/substrate-api-sidecar into feat-experiment-plo-endpoints
Co-authored-by: Tarik Gul <47201679+TarikGul@users.noreply.github.com>
Sanity and edge cases manually tested:
Let me know if you can think of other potential tests. |
We could do a check in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, bug issue was talked over and resolved. currently implementation is right.
* fix: typefactory, and cleanup mockApi
Co-authored-by: David <dvdplm@gmail.com>
@dvdplm everything from your reviews should be addressed now |
Overview
This PR introduces the following endpoints for parachain lease offerings:
/experimnetal/paras
/experimental/paras/auctions/current
/experimental/paras/{paraId}/crowdloan-info
/experimental/paras/crowdloans
/experimental/paras/{paraId}/lease-info
/experimental/paras/leases/current
These are considered experimental as we may break the API without bumping api-sidecar's major version.
Closes: #490
cc @CurlyBracketEffect @joepetrowski