Properly declare errors in pallets that use decl_module (#8523)

* Properly declare errors in pallets that use decl_module * Remove extra error type declaration
paritytech · Apr 3, 2021 · d19c0e1 · d19c0e1
1 parent 52d5e19
commit d19c0e1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/frame/lottery/src/lib.rs b/frame/lottery/src/lib.rs
@@ -209,6 +209,8 @@ decl_error! {
 
 decl_module! {
 	pub struct Module<T: Config> for enum Call where origin: T::Origin, system = frame_system {
+		type Error = Error<T>;
+
 		const ModuleId: ModuleId = T::ModuleId::get();
 		const MaxCalls: u32 = T::MaxCalls::get() as u32;
 

diff --git a/frame/membership/src/lib.rs b/frame/membership/src/lib.rs
@@ -113,6 +113,8 @@ decl_module! {
 		for enum Call
 		where origin: T::Origin
 	{
+		type Error = Error<T, I>;
+
 		fn deposit_event() = default;
 
 		/// Add a member `who` to the set.

diff --git a/frame/tips/src/lib.rs b/frame/tips/src/lib.rs
@@ -195,7 +195,6 @@ decl_module! {
 		for enum Call
 		where origin: T::Origin
 	{
-
 		/// The period for which a tip remains open after is has achieved threshold tippers.
 		const TipCountdown: T::BlockNumber = T::TipCountdown::get();