Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Properly declare errors in pallets that use decl_module #8523

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Properly declare errors in pallets that use decl_module #8523

merged 2 commits into from
Apr 3, 2021

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Apr 3, 2021

Resolves #8501.

@shawntabrizi
Copy link
Member

thats all of em? lol

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 3, 2021
@shawntabrizi shawntabrizi added the A0-please_review Pull request needs code review. label Apr 3, 2021
@shawntabrizi shawntabrizi added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Apr 3, 2021
@bkchr bkchr merged commit d19c0e1 into paritytech:master Apr 3, 2021
@KiChjang KiChjang deleted the error-decl branch April 4, 2021 06:02
hirschenberger pushed a commit to hirschenberger/substrate that referenced this pull request Apr 14, 2021
@KiChjang @hirschenberger
Properly declare errors in pallets that use decl_module (paritytech#8523
59817f1 
)

* Properly declare errors in pallets that use decl_module

* Remove extra error type declaration
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Error declaration in some pallets
3 participants
@KiChjang @shawntabrizi @bkchr