Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Nodes connect to themselves #373

Closed
tomaka opened this issue Jul 18, 2018 · 3 comments · Fixed by #2783
Closed

Nodes connect to themselves #373

tomaka opened this issue Jul 18, 2018 · 3 comments · Fixed by #2783
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Milestone

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 18, 2018

It appears that node connect to themselves when they perform Kademlia queries.
Fortunately they don't connect to themselves when it comes to the actual dot protocol.

@tomaka tomaka added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Jul 18, 2018
@gavofyork
Copy link
Member

Is this still an issue?

@tomaka
Copy link
Contributor Author

tomaka commented Jul 25, 2018

Yes: libp2p/rust-libp2p#341

@gavofyork gavofyork added this to the 1.0 milestone Sep 5, 2018
@tomaka
Copy link
Contributor Author

tomaka commented Jun 3, 2019

Fixed by libp2p/rust-libp2p#1097.
The fix is not in Substrate yet, though.
Once a new version of libp2p is published, we can update Substrate to use it, and close this.

lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
* Update to use [u8; 65] for EcdsaSignature

* Fix warning
JoshOrndorff pushed a commit to moonbeam-foundation/substrate that referenced this issue Apr 21, 2021
* Crude attempt at finding open ports (paritytech#346)

* added example test for frontier (paritytech#343)

* added example test for frontier

* added npm run non-ci-test

* move staking test spec to node/chainspec (paritytech#335)

* init

* hide staking test spec behind test-staking feature flag

* clean

* comment staking test genesis config for readability

* move test spec to separate file

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

Co-authored-by: Antoine Estienne <estienne.antoine@gmail.com>
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
Co-authored-by: Crystalin <alan@purestake.com>

* Crystalin testweek watch (paritytech#347)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

Co-authored-by: Stephen Shelton <steve@brewcraft.org>

* Unskip tests (paritytech#357)

* Unskip `fetch genesis block by hash`

* Remove timeouts

* Unskip block gas limit tests

* Remove `opt-level = 0` from Cargo.toml

* Unskip

* Test contract factory (paritytech#351)

* added deployContractByName and  contractSources

* added getcompiled function

* increase timeout for testfilterapi

* change contract name and add sourcecode

* Fix fixture requirement

* update package and json

Co-authored-by: Crystalin <alan@purestake.com>

* Gorka remove intra test dependencies (paritytech#355)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Crystalin <alan@purestake.com>

* Crystalin remove solc (paritytech#362)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

* Removes solc from tests

* Fixes path for contract tests

* Adds formatting for compiled contracts

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Gorka Irazoqui <gorka.irazoki@gmail.com>

* Typescript test refactoring (paritytech#364)

* Crude attempt at finding open ports

* npx -w

* Add missing file

* Adds random port and parallel test execution

* Fixed ethers test

* Adds delay to node start in test

* Adds support for test watch

* Cleaned package.json

* Prevent test to run at start of watch

* Restore optimization for cargo build

* Allow for non-finalization and ParentHash specification in createAndFinalizeBlock

* Make test-block tests non-dependent by using non-finalized chains

* Separate tests to make them non-dependent and parametrize tx hashes and nonces in test-txpool

* it instead of step in test-version

* setup providers before tests in test-ethers.ts

* Create a block before tests to avoid one depend on the other in test-nonce

* it for step in test-receipt

* import constants for test-staking

* Attemp at parametrizing test-filter-api tests

* attemp at parametrizing test-revert-receipt

* remove mocha-steps from tests

* make test-subscription tests non-dependent

* comply with prettier

* Add support for retrieving the hash of the generated block

* Make test-trace-filter tests non-dependent

* balance-tests non-dependent

* Non-dependent tests for test-polkadot-api

* Add test-fork-chain tests

* remove unnecesary timeouts

* Use context provider for test-ether.ts

* Remove currentId from test-filter-api since we are uninstalling all filters from test to test

* Join balance test setups and check balance at each block

* Rename variables to camelCase in tests

* small introduced bug in test-pool-pending when camelCasing variables

* Use a different account for test-revert-receipt deployment contract to avoid non-determinism of the nonce

* shorten line because of editconfig

* Separate test-subscription and test-subscription-past-events.ts

* remove single letter variable in test-filter-api

* Small cosmetic changes

* revert changes in package.json

* Remove beforeEach and substitute it for common function

* change var for let or const

* Removes solc from tests

* Fixes path for contract tests

* Adds formatting for compiled contracts

* Refactor tests

* Fix formatting

* Limit concurrency to half cpus for ts tests

* Fixes github action typo

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Gorka Irazoqui <gorka.irazoki@gmail.com>

* Antoine update testweek readme typos (paritytech#369)

* added instructions to readme

* update package lock

* Add missing contracts to definition (paritytech#368)

* Add Callee, Caller, Incrementer

* Update test-trace

* Remove unused

* Move blockscout tracer to util/tracer

* Test for txpool multiple transactions (paritytech#367)

* Improve pending pool test

* Rephrase comment

* Better naming for txpool tests

* Split txpool multiple test for more independance

* Fixes few test expectations

* Adds test for future transaction

* Rename eth pool correctly

* Fixes node listeners

Co-authored-by: tgmichel <telmo@purestake.com>

* Fixes typo in variable name

* Added test for block gas in smart contract (paritytech#370)

* VSCode debugger (support for TS tests) (paritytech#348)

Add a VSCode debugger config with CodeLLDB.
TS tests can be debugged by first starting the node in the debugger, then launching DEBUG_MODE=true npm run test-single in the test folder (modify package.json to change the test file).

* Adds test for filter trace pagination (paritytech#373)

* Fixes trace filter test

Co-authored-by: Stephen Shelton <steve@brewcraft.org>
Co-authored-by: Antoine Estienne <estienne.antoine@gmail.com>
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
Co-authored-by: tgmichel <telmo@purestake.com>
Co-authored-by: girazoki <gorka.irazoki@gmail.com>
Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com>
liuchengxu added a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
* Remove staging and testnet spec

* Remove unused blockauthor key

* Remove unused event and error

* Delete unused weight_info.rs
liuchengxu pushed a commit to autonomys/substrate that referenced this issue Jun 3, 2022
helin6 pushed a commit to boolnetwork/substrate that referenced this issue Jul 25, 2023
* WIP config

* WIP separate default config

* Separate trait impls on client

* WIP introduce new ApiConfig (to be renamed) trait

* Update generated polkadot codegen

* Allow configuring Config and Extra types independently

* Add extra default configuration

* Revert ir parsing of config attr

* Add default-features = false to substrate deps

* Revert "Add default-features = false to substrate deps"

This reverts commit 099d20cd4cbf8000ff938d1dc090ecbc28a5e788.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants