Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move ss58-registry into its own crate #9696

Closed
bkchr opened this issue Sep 4, 2021 · 1 comment · Fixed by #9755
Closed

Move ss58-registry into its own crate #9696

bkchr opened this issue Sep 4, 2021 · 1 comment · Fixed by #9755
Assignees
Labels
I7-refactor Code needs refactoring.

Comments

@bkchr
Copy link
Member

bkchr commented Sep 4, 2021

The ss58-registry currently exists as the following json file: https://github.com/paritytech/substrate/blob/master/ss58-registry.json and once in code here: https://github.com/paritytech/substrate/blob/master/primitives/core/src/crypto.rs#L486

As it is generally a bad idea that we have two places for the same information, we should merge them. This was the idea from the beginning of the json file. So the following needs to be done:

  1. Create a new crate in a separate repo (the name of the repo and crate needs to be decided on).
  2. The repo contains the json file and this crate.
  3. The crate parses at compile time the json file and generates the proper Ss58AddressFormat enum.
  4. Release and integrate this crate into substrate.
@bkchr bkchr added the I7-refactor Code needs refactoring. label Sep 4, 2021
@gilescope
Copy link
Contributor

gilescope commented Sep 4, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants