Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Extract smart-contract runtime into the separate crate #179

Merged
merged 3 commits into from
Jun 5, 2018

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented May 29, 2018

Goes in after #192

Smart-contract executing moved out from substrate-runtime-staking module.

Hence staking/src/contract.rs is removed and staking/src/mock.rs is merged back into lib.rs since it's used only in lib.rs.

@pepyakin pepyakin added the A0-please_review Pull request needs code review. label May 29, 2018
(i32.const 4) ;; Pointer to "Transfer to" address.
(i32.const 8) ;; Length of "Transfer to" address.
(i32.const 12) ;; Pointer to the buffer with value to transfer
(i32.const 8) ;; Length of the buffer with value to transfer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs instead of spaces.

;; Represented by u64 (8 bytes long) in little endian.
(data (i32.const 4) "\02\00\00\00\00\00\00\00")
;; Amount of value to transfer.
;; Represented by u64 (8 bytes long) in little endian.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed tabs/spaces

Copy link
Member

@gavofyork gavofyork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs resolving and those bits of whitespace sorting.

@pepyakin pepyakin force-pushed the ser-contract-extract-crate branch 4 times, most recently from 02a175b to fbcea41 Compare June 1, 2018 13:57
@gavofyork
Copy link
Member

one more little resolve...

@pepyakin pepyakin force-pushed the ser-contract-extract-crate branch from fbcea41 to b49884c Compare June 4, 2018 07:55
@pepyakin pepyakin added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jun 4, 2018
@pepyakin pepyakin force-pushed the ser-contract-extract-crate branch from b49884c to 1aeeae8 Compare June 5, 2018 09:29
@gavofyork gavofyork merged commit 817c4a7 into master Jun 5, 2018
@gavofyork gavofyork deleted the ser-contract-extract-crate branch June 5, 2018 12:18
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Impl Mining Asset RPC

* .

* Rename XTypeAssetPowerMap to FixedAssetPowerOf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants