Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use --export-table from the latest LLD [2] #325

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Conversation

pepyakin
Copy link
Contributor

Cleaning fallout after paritytech/polkadot#316

Despite all tests passed in #316, it was discovered that when running

./build.sh
cargo test -p substrate-executor

there was some errors which clearly came after #316. It turned out that table was renamed to __indirect_function_table and for some reason wasm binaries in #316 was built with old rustc + wasm-export-table somehow.

This time the PR is tested with:

git clean -xfd && ./build.sh && cargo test --all

@pepyakin pepyakin added the A0-please_review Pull request needs code review. label Jul 15, 2018
@gavofyork gavofyork added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-please_review Pull request needs code review. labels Jul 15, 2018
@arkpar arkpar merged commit cae3c20 into master Jul 15, 2018
@arkpar arkpar deleted the ser-use-lld-export-table-2 branch July 15, 2018 18:12
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* Improved execution & tests

* Style

* Made CLI arg const

* Moved Upwards message

* CLI subcommand for validation worker

* Build halting parachain

* Build halting parachain

* Made stuff private

* Reorganized parachain tests

* Comment

* Whitespace

* Apply suggestions from code review

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* Fixed call data size check and introduced an enum

* Apply suggestions from code review

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
liuchengxu pushed a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
liuchengxu pushed a commit to autonomys/substrate that referenced this pull request Jun 3, 2022
…aritytech#325)

* Fix subspace_wasm_tools

* Update target directory finding control flow and add comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants