Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 12 release compiling failed #1545

Closed
beiguancyc opened this issue Sep 17, 2020 · 11 comments
Closed

Xcode 12 release compiling failed #1545

beiguancyc opened this issue Sep 17, 2020 · 11 comments

Comments

@beiguancyc
Copy link

Using Xcode 12 release compiling for an iOS Simulator running iOS 14, the app cannot compile when the Parse pod is installed.

Repro steps
pod 'Parse','~> 1.19.0'
Then build and run,
image

@idefen1
Copy link

idefen1 commented Sep 17, 2020

Got it.

Switch '@import Bolts' to '#import <Bolts/Bolts.h>' and my project compiled.

Hope this helps.

@beiguancyc
Copy link
Author

Got it.

Switch '@import Bolts' to '#import <Bolts/Bolts.h>' and my project compiled.

Hope this helps.

That is not a good idea

@idefen1
Copy link

idefen1 commented Sep 17, 2020

Got it.
Switch '@import Bolts' to '#import <Bolts/Bolts.h>' and my project compiled.
Hope this helps.

That is not a good idea

I'm sorry =\ I don't know what else to do... I need to compile my code and this is the only way I can get it to work. Maybe someone else will help us find a fix.

@beiguancyc
Copy link
Author

Got it.
Switch '@import Bolts' to '#import <Bolts/Bolts.h>' and my project compiled.
Hope this helps.

That is not a good idea

I'm sorry =\ I don't know what else to do... I need to compile my code and this is the only way I can get it to work. Maybe someone else will help us find a fix.

I think it will be fixed soon.

@idefen1
Copy link

idefen1 commented Sep 17, 2020

Got it.
Switch '@import Bolts' to '#import <Bolts/Bolts.h>' and my project compiled.
Hope this helps.

That is not a good idea

I'm sorry =\ I don't know what else to do... I need to compile my code and this is the only way I can get it to work. Maybe someone else will help us find a fix.

I think it will be fixed soon.

Just a quick question: Why is my quick fix 'not a good idea'. My application appears to be compiling and working as expected? If I need to submit, what risk am I taking? Thanks!

@gutoim
Copy link

gutoim commented Sep 18, 2020

I think this is the fix. The build error occurs when building pod (including Parse) into a static library. Using @import Bolts requires using use_frameworks! in Podfile, which for sure I do not want.

@theextremeprogrammer
Copy link
Contributor

theextremeprogrammer commented Sep 19, 2020

Just a quick question: Why is my quick fix 'not a good idea'. My application appears to be compiling and working as expected? If I need to submit, what risk am I taking? Thanks!

@idefen1 Based on my understanding of how Cocoapods works, if you change this line of code then anytime you update or refresh your pods then this change will be deleted. So while this may work for right now as a temporary solution, ideally the long term solution would be to have this change (or the appropriate change) made to the Parse SDK itself so that you (and me and others) don't have to continue to manually make this fix in the future.

theextremeprogrammer added a commit to theextremeprogrammer/Parse-SDK-iOS-OSX that referenced this issue Sep 19, 2020
…al #import

- Fixes compilation error for Bolts in Xcode 12
theextremeprogrammer added a commit to theextremeprogrammer/Parse-SDK-iOS-OSX that referenced this issue Sep 19, 2020
@findlife99
Copy link

findlife99 commented Sep 21, 2020

Hi,

I also face the same problem, how can I solve it ?

@theextremeprogrammer
Copy link
Contributor

Hi,

I also face the same problem, how can I solve it ?

@findlife99 The fix mentioned in this comment worked for me - however, as I noted above, making a change to the pod source code should be considered temporary, so I made a PR to be considered for inclusion in a future build.

drdaz pushed a commit that referenced this issue Sep 21, 2020
* #1545 Updates Bolts import from module @import to global #import

- Fixes compilation error for Bolts in Xcode 12

* #1545 Update #import to conform to existing style
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. If you believe it should stay open, please let us know! As always, we encourage contributions, check out the Contributing Guide

@stale stale bot added the Stale label Nov 8, 2020
@theextremeprogrammer
Copy link
Contributor

Doesn't look like I have the ability to close this issue, but since the PR was merged I think was can close this. @TomWFox @drdaz could I trouble you to assist? Thanks! =)

@TomWFox TomWFox closed this as completed Nov 8, 2020
@TomWFox TomWFox removed the Stale label Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants