Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes xcode12 bolts compile error #1548

Conversation

theextremeprogrammer
Copy link
Contributor

First of all - thanks to the maintainers for your work on this project! It was a relief (and still is) to not have to migrate off of Parse.

Contribution guidelines
[x] 1. Fork the repo and create your branch from master.
[x] 2. Add unit tests for any new code you add. → No new code added, so I did not add any tests.
[x] 3. If you've changed APIs, update the documentation and the iOS Guide
[x] 4. Ensure the test suite passes. → Tests around extensions failed both with and without my changes; these do not seem to be related to this change.
[x] 5. Make sure your code follows the style guide

This PR is a simple fix for issue #1545 based on the discussion that was there.

When I compiled the code locally it indicated an import error for @import Bolts however Xcode still let everything compile. It was only once I had this imported in my application that the error caused my app to not compile.

Taking a look at the code, it seemed that anything that was using ParseInternal.h needed to use system-level #import <filename.h> as opposed to module-level imports @import module. This was the only module-level import in that hierarchy of file imports.

Thanks to @idefen1 for providing the original suggestion for the fix!

Please let me know if there's anything else that needs to be adjusted.

@theextremeprogrammer theextremeprogrammer changed the title Fixes xcode12 bolts compile error #1545 Fixes xcode12 bolts compile error Sep 19, 2020
@drdaz
Copy link
Member

drdaz commented Sep 21, 2020

Thanks for this!

@drdaz drdaz merged commit bad33e5 into parse-community:master Sep 21, 2020
@theextremeprogrammer theextremeprogrammer deleted the fix-xcode12-bolts-compile-error branch November 8, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants