Fixes xcode12 bolts compile error #1548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all - thanks to the maintainers for your work on this project! It was a relief (and still is) to not have to migrate off of Parse.
Contribution guidelines
[x] 1. Fork the repo and create your branch from master.
[x] 2. Add unit tests for any new code you add. → No new code added, so I did not add any tests.
[x] 3. If you've changed APIs, update the documentation and the iOS Guide
[x] 4. Ensure the test suite passes. → Tests around extensions failed both with and without my changes; these do not seem to be related to this change.
[x] 5. Make sure your code follows the style guide
This PR is a simple fix for issue #1545 based on the discussion that was there.
When I compiled the code locally it indicated an import error for
@import Bolts
however Xcode still let everything compile. It was only once I had this imported in my application that the error caused my app to not compile.Taking a look at the code, it seemed that anything that was using
ParseInternal.h
needed to use system-level#import <filename.h>
as opposed to module-level imports@import module
. This was the only module-level import in that hierarchy of file imports.Thanks to @idefen1 for providing the original suggestion for the fix!
Please let me know if there's anything else that needs to be adjusted.