Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ion-rs to ion-rs_old in preparation of upgrade #492

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Sep 5, 2024


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 September 5, 2024 17:15
Copy link

github-actions bot commented Sep 5, 2024

Conformance comparison report

Base (deff7a8) f23d693 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (deff7a8) but now fail: 0

Number failing in Base (deff7a8) but now pass: 0

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (deff7a8) to head (3071a1e).
Report is 1 commits behind head on dev-ion-doc.

Files with missing lines Patch % Lines
extension/partiql-extension-ion/src/lib.rs 98.76% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           dev-ion-doc     #492      +/-   ##
===============================================
- Coverage        80.54%   80.48%   -0.07%     
===============================================
  Files               70       70              
  Lines            19040    18934     -106     
  Branches         19040    18934     -106     
===============================================
- Hits             15336    15239      -97     
- Misses            3257     3270      +13     
+ Partials           447      425      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpschorr jpschorr merged commit 370bb96 into dev-ion-doc Sep 5, 2024
19 checks passed
@jpschorr jpschorr deleted the dev-feat-upgrade-ion branch September 5, 2024 17:44
jpschorr added a commit that referenced this pull request Sep 17, 2024
* Rename `ion-rs` to `ion-rs_old` in preparation of upgrade (#492)

* Refactor lexer into module & upgrade lexer & parser dependencies (#493)

* Upgrade project deps to latest; use semver, not wildcard nor tilde (#494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants