Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge fixes from dev-ion-doc feature branch back to main #497

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

jpschorr
Copy link
Contributor

Merge behavior-preserving fixes/cleanup/upgrades from dev-ion-doc branch to main

All commits have already been PRed; this is just merging them back into main.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr changed the title Dev ion doc Merge fixes from dev-ion-doc feature branch back to main Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 96.98276% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (deff7a8) to head (7a8a028).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
partiql-parser/src/lexer/mod.rs 96.77% 0 Missing and 12 partials ⚠️
partiql-parser/src/lexer/partiql.rs 96.77% 4 Missing ⚠️
partiql-parser/src/lexer/comment.rs 96.55% 2 Missing ⚠️
partiql-parser/src/lexer/embedded_ion.rs 96.36% 2 Missing ⚠️
extension/partiql-extension-ion/src/lib.rs 98.76% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   80.54%   80.49%   -0.06%     
==========================================
  Files          70       73       +3     
  Lines       19040    18947      -93     
  Branches    19040    18947      -93     
==========================================
- Hits        15336    15251      -85     
- Misses       3257     3271      +14     
+ Partials      447      425      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Conformance comparison report

Base (deff7a8) 8098cea +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (deff7a8) but now fail: 0

Number failing in Base (deff7a8) but now pass: 0

@jpschorr jpschorr merged commit 70b5ea2 into main Sep 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants