-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible Sequence drawing #385
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general style remarks, to be discussed and that could be applied later.
@CdeTerra I agree with your remarks in general, I admit I tend to be more careless with functions for plotting because I don't expect people to read their contents often, but it's a bad habit. I'll give your suggestions a shot before merging, if I find they're not so hard to implement I'll still include them here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes! Small new comments, but approving in general.
draw_phase_curve
) in drawing methodsExamples:
draw_phase_curve=True. The detuning is still omitted if not used (as happens for the
"raman_local"` channel)To Do:
_seq_drawer.gather_data()
function, as is still the case for the amplitude and detuning. As outlined in Sequence sampler feature extension #349, we would like these to come from the sampler instead.Closes #332 .