(#713) Change default icon font size #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Site: Grid add more detailed docs about various containers
…ewtypes ViewType object accepts href | Fixes liferay#641
Rename hideLabel params to showLabel for consistency
…ibutes) when needed.
Add testSoy task to travis
Add `cors` to fetch options
…onsMenus Fixes the quick action style in ClayManagementToolbar | Fixes liferay#738
Fix tag type JSDOC when use multiple types | Fixes liferay#736
Adds new JSDOC tags to ChartBase
Updates billboard.js to 1.3.0
…eation-menu Improve Creation Menu items logic | Fixes liferay#749
v2.0.0-rc.10
|
New Pull: liferay#779 Hey Justin, This is the right way to go about it. Generally it's variables first, then add css. I just have some suggestions for the commit message. If you use any of these keywords https://help.github.com/articles/closing-issues-using-keywords/ along with the issue number github will automatically close the issue when it gets merged into master. I also use Breaking, New, Update, Site at the beginning of my commit messages to denote what kind of change it is. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liferay#713
Not sure if it was better to do this or to change
heightandwidthto16pxin.btn-monospaced.btn .lexicon-icon@jonmak08