Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior #10066

Merged
merged 2 commits into from
Mar 26, 2024
+2 −2
Merged

fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior #10066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca6b3f
fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior
kmcfaul Feb 6, 2024
2772aae
revamp toggle click for checkbox
kmcfaul Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/MenuToggle/MenuToggleCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class MenuToggleCheckbox extends React.Component<MenuToggleCheckboxProps, { ouia
</span>
);
return (
<label className={css(styles.check, !children && styles.modifiers.standalone, className)} htmlFor={id}>
<label className={css(styles.check, !children && styles.modifiers.standalone, className)}>
<input
className={css(styles.checkInput)}
{...(this.calculateChecked() !== undefined && { onChange: this.handleChange })}
Expand All @@ -93,7 +93,7 @@ class MenuToggleCheckbox extends React.Component<MenuToggleCheckboxProps, { ouia
ref={(elem) => elem && (elem.indeterminate = isChecked === null)}
aria-invalid={!isValid}
disabled={isDisabled}
{...(defaultChecked !== undefined ? { defaultChecked } : { checked: isChecked })}
{...(defaultChecked !== undefined ? { defaultChecked } : { checked: this.calculateChecked() })}
{...getOUIAProps(
MenuToggleCheckbox.displayName,
ouiaId !== undefined ? ouiaId : this.state.ouiaStateId,
Expand Down
Loading