-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase v6 #9899
Merged
Merged
Rebase v6 #9899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @patternfly/react-code-editor@5.2.0-prerelease.20 - @patternfly/react-core@5.2.0-prerelease.20 - @patternfly/react-docs@6.2.0-prerelease.20 - demo-app-ts@5.1.1-prerelease.43 - @patternfly/react-table@5.2.0-prerelease.20
* fix(Text input): Added aria-expanded * add interface * updates from review
…rawer item read state (patternfly#9569) * fix(Notification Drawer): Added screen reader text for notification drawer item read state * fix snapshot * Update prop description * add aria-live * update snapshots
…y#9709) * feat: ability to add props to WizardFooter buttons * fix(WizardFooter): null check * fix(Wizard): simpler design of adding footer buttons props * test(Wizard): can add props to footer buttons * docs(WizardFooter): move comment so docs have correct description * refactor(WizardFooter): move FooterButtonProps to types file
* chore(Divider): update tests to new standards * changes from PR review
- @patternfly/react-code-editor@5.2.0-prerelease.21 - @patternfly/react-core@5.2.0-prerelease.21 - @patternfly/react-docs@6.2.0-prerelease.21 - demo-app-ts@5.1.1-prerelease.44 - @patternfly/react-table@5.2.0-prerelease.21
…es (patternfly#9347) * bug(build): fixed built ESM files importing CJS files from react-styles * edited yarn.lock to invalidate deps cache in GH actions * excluded file extensions from react-styles path transform in ESM build * updated jest config to transform .mjs files * updated pr action to invalidate deps cache if package files added/edited * chore(deps): Add ts-node to support executing typescript files directly
- @patternfly/react-code-editor@5.2.0-prerelease.22 - @patternfly/react-core@5.2.0-prerelease.22 - @patternfly/react-docs@6.2.0-prerelease.22 - demo-app-ts@5.1.1-prerelease.45 - @patternfly/react-table@5.2.0-prerelease.22 - transformer-react-styles-esm-imports@1.0.1-prerelease.0
…lease.4 (patternfly#9780) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-charts@7.2.0-prerelease.6 - @patternfly/react-code-editor@5.2.0-prerelease.23 - @patternfly/react-core@5.2.0-prerelease.23 - @patternfly/react-docs@6.2.0-prerelease.23 - @patternfly/react-icons@5.2.0-prerelease.6 - demo-app-ts@5.1.1-prerelease.46 - @patternfly/react-styles@5.2.0-prerelease.4 - @patternfly/react-table@5.2.0-prerelease.23 - @patternfly/react-tokens@5.2.0-prerelease.5
…ly#9048 (patternfly#9087) * feat(Datalist): implement full page Basic demo to match HTML patternfly#9048 * fix syntax error * comments applied * comments applied * comments applied * comments applied * \xa0 comments applied * move key per review comments * address PR comments * revert change to package.json * Converted basic demo to TS --------- Co-authored-by: nicolethoen <nthoen@redhat.com> Co-authored-by: Eric Olkowski <thatblindgeye@gmail.com>
- @patternfly/react-code-editor@5.2.0-prerelease.24 - @patternfly/react-core@5.2.0-prerelease.24 - @patternfly/react-docs@6.2.0-prerelease.24 - demo-app-ts@5.1.1-prerelease.47 - @patternfly/react-table@5.2.0-prerelease.24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…lease.5 (patternfly#9806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-charts@7.2.0-prerelease.7 - @patternfly/react-code-editor@5.2.0-prerelease.25 - @patternfly/react-core@5.2.0-prerelease.25 - @patternfly/react-docs@6.2.0-prerelease.25 - @patternfly/react-icons@5.2.0-prerelease.7 - demo-app-ts@5.1.1-prerelease.48 - @patternfly/react-styles@5.2.0-prerelease.5 - @patternfly/react-table@5.2.0-prerelease.25 - @patternfly/react-tokens@5.2.0-prerelease.6
- @patternfly/react-code-editor@5.2.0-prerelease.26 - @patternfly/react-core@5.2.0-prerelease.26 - @patternfly/react-docs@6.2.0-prerelease.26 - demo-app-ts@5.1.1-prerelease.49 - @patternfly/react-table@5.2.0-prerelease.26
- @patternfly/react-code-editor@5.2.0-prerelease.27 - @patternfly/react-core@5.2.0-prerelease.27 - @patternfly/react-docs@6.2.0-prerelease.27 - demo-app-ts@5.1.1-prerelease.50 - @patternfly/react-table@5.2.0-prerelease.27
* clean up instances of Array.apply * rename item to value
- @patternfly/react-code-editor@5.2.0-prerelease.28 - @patternfly/react-core@5.2.0-prerelease.28 - @patternfly/react-docs@6.2.0-prerelease.28 - @patternfly/react-integration@5.1.1-prerelease.15 - demo-app-ts@5.1.1-prerelease.51 - @patternfly/react-table@5.2.0-prerelease.28
- @patternfly/react-code-editor@5.2.0-prerelease.29 - @patternfly/react-core@5.2.0-prerelease.29 - @patternfly/react-docs@6.2.0-prerelease.29 - @patternfly/react-icons@5.2.0-prerelease.8 - demo-app-ts@5.1.1-prerelease.52 - @patternfly/react-table@5.2.0-prerelease.29
* add spread prop test, update test * chore(DataList): update tests * fix merge error * break out into separate files, pr feedback * updates * fix some example ids * minor test updates * revert action change
* bug(ClipboardCopy): change children type to string Signed-off-by: gitdallas <dallas.nicol@gmail.com> * fix clipboardcopyexpanded to work with string children Signed-off-by: gitdallas <dallas.nicol@gmail.com> * refactor a bit * fix bad rebase --------- Signed-off-by: gitdallas <dallas.nicol@gmail.com>
* fix conflicts * docs(select): Adds documentation for React examples. * Adds content to new select React examples. * Updates typeahead with create example. * Clarify mult typeahead with create content. * Finalizing wording. * Updates content from review. --------- Co-authored-by: nicolethoen <nthoen@redhat.com>
- @patternfly/react-code-editor@5.2.0-prerelease.32 - @patternfly/react-core@5.2.0-prerelease.32 - @patternfly/react-docs@6.2.0-prerelease.32 - demo-app-ts@5.1.1-prerelease.55 - @patternfly/react-table@5.2.0-prerelease.32
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(Table): make tooltip prop consistent * make tooltip ReactNode and add tooltipProps to Th * add prop to useEffect * fix logic for keyboard focus * fix useeffect
* convert data list react demo to TS * update function component name to match file
- @patternfly/react-code-editor@5.2.0-prerelease.33 - @patternfly/react-core@5.2.0-prerelease.33 - @patternfly/react-docs@6.2.0-prerelease.33 - demo-app-ts@5.1.1-prerelease.56 - @patternfly/react-table@5.2.0-prerelease.33
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-code-editor@5.2.0-prerelease.34 - @patternfly/react-core@5.2.0-prerelease.34 - @patternfly/react-docs@6.2.0-prerelease.34 - demo-app-ts@5.1.1-prerelease.57 - @patternfly/react-table@5.2.0-prerelease.34
…lease.7 (patternfly#9867) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-charts@7.2.0-prerelease.8 - @patternfly/react-code-editor@5.2.0-prerelease.35 - @patternfly/react-core@5.2.0-prerelease.35 - @patternfly/react-docs@6.2.0-prerelease.35 - @patternfly/react-icons@5.2.0-prerelease.9 - demo-app-ts@5.1.1-prerelease.58 - @patternfly/react-styles@5.2.0-prerelease.6 - @patternfly/react-table@5.2.0-prerelease.35 - @patternfly/react-tokens@5.2.0-prerelease.7
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/react-code-editor@5.2.0-prerelease.36 - @patternfly/react-core@5.2.0-prerelease.36 - @patternfly/react-docs@6.2.0-prerelease.36 - @patternfly/react-integration@5.1.1-prerelease.16 - demo-app-ts@5.1.1-prerelease.59 - @patternfly/react-table@5.2.0-prerelease.36
tlabaj
requested review from
jenny-s51,
mfrances17,
kmcfaul and
thatblindgeye
December 18, 2023 14:04
Preview: https://patternfly-react-pr-9899.surge.sh A11y report: https://patternfly-react-pr-9899-a11y.surge.sh |
thatblindgeye
approved these changes
Dec 18, 2023
nicolethoen
approved these changes
Dec 18, 2023
jenny-s51
approved these changes
Dec 18, 2023
mfrances17
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9864