Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase v6 #9899

Merged
merged 60 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
d7308ae
fix(RTL): added right-to-left page demo (#9694)
mcoker Nov 2, 2023
e9f0b21
chore(release): releasing packages [ci skip]
patternfly-build Nov 2, 2023
4d4d623
fix(Wizard): onStepChange - skip isDisabled & isHidden (#9748)
jpuzz0 Nov 2, 2023
7f6a62c
fix(Text input): Added aria-expanded (#9705)
tlabaj Nov 2, 2023
bc19f91
fix(Notification Drawer): Added screen reader text for notification d…
tlabaj Nov 2, 2023
9f21cee
feat(Wizard): ability to add props to WizardFooter buttons (#9709)
adamviktora Nov 2, 2023
7eff077
chore(Divider): update tests to new standards (#9714)
mfrances17 Nov 2, 2023
4f459eb
chore(release): releasing packages [ci skip]
patternfly-build Nov 2, 2023
a772c6d
fix(TreeView): define button type (#9770)
kmcfaul Nov 2, 2023
817e9bd
bug(build): fixed built ESM files importing CJS files from react-styl…
wise-king-sullyman Nov 2, 2023
5febe85
chore(release): releasing packages [ci skip]
patternfly-build Nov 2, 2023
fc2907d
chore(deps): update dependency @patternfly/patternfly to v5.2.0-prere…
renovate[bot] Nov 3, 2023
559e6fd
chore(release): releasing packages [ci skip]
patternfly-build Nov 3, 2023
ab18059
feat(Datalist): implement full page Basic demo to match HTML #9048 (#…
Kells512 Nov 3, 2023
981361e
fix(ClipboardCopy): kepp caret position (#9772)
adamviktora Nov 3, 2023
74773b0
chore(release): releasing packages [ci skip]
patternfly-build Nov 3, 2023
b3345c2
chore(deps): update devdependencies (#9757)
renovate[bot] Nov 6, 2023
3131ff6
chore(deps): update dependency @patternfly/patternfly to v5.2.0-prere…
renovate[bot] Nov 10, 2023
93db0ff
chore(deps): update devdependencies (#9800)
renovate[bot] Nov 10, 2023
75442bf
chore(release): releasing packages [ci skip]
patternfly-build Nov 10, 2023
a12cf31
fix(DatePicker): updated logic for parsing and focus management (#9794)
thatblindgeye Nov 13, 2023
9dccfa9
chore(release): releasing packages [ci skip]
patternfly-build Nov 13, 2023
bf96edb
chore(PrimaryDetail): convert demos to TS (#9787)
jenny-s51 Nov 14, 2023
42fd765
chore(release): releasing packages [ci skip]
patternfly-build Nov 14, 2023
705e9ff
chore(misc): clean up instances of Array.apply (#9798)
jenny-s51 Nov 14, 2023
e96ac1d
chore(release): releasing packages [ci skip]
patternfly-build Nov 14, 2023
9b9622d
chore(eslint): Added React Testing Library linter plugin (#9805)
wise-king-sullyman Nov 14, 2023
4f123b1
chore(release): releasing packages [ci skip]
patternfly-build Nov 14, 2023
2a70043
chore(DataList): update tests (#9672)
kmcfaul Nov 15, 2023
a414253
bug(ClipboardCopy): change children type to string (#9743)
gitdallas Nov 15, 2023
88e1c34
chore(deps): update devdependencies (#9817)
renovate[bot] Nov 15, 2023
4b23675
fix Search Input - composable advanced search demo (#9484)
MariaAga Nov 15, 2023
a7075e0
docs(custom menu): add example with search input inline filtering (#9…
adamviktora Nov 15, 2023
a816ddd
chore(HelperText): update tests (#9761)
kmcfaul Nov 15, 2023
18c140a
fix(Chip): update tooltip vis when chip updates (#9819)
kmcfaul Nov 16, 2023
b957f2f
chore(DescriptionList): update tests (#9753)
kmcfaul Nov 16, 2023
e112034
chore(release): releasing packages [ci skip]
patternfly-build Nov 16, 2023
7d2fd26
chore(TreeView): updated tests (#9773)
thatblindgeye Nov 16, 2023
feeb331
chore(Table) convert demos to ts (#9621)
Dominik-Petrik Nov 17, 2023
3fa692c
chore(release): releasing packages [ci skip]
patternfly-build Nov 17, 2023
fc8f6eb
chore(deps): update devdependencies (#9829)
renovate[bot] Nov 20, 2023
7a2f775
docs(select): Adds documentation to React examples. (#9536)
edonehoo Nov 21, 2023
32dfd89
chore(release): releasing packages [ci skip]
patternfly-build Nov 21, 2023
9b96292
chore(deps): update devdependencies (#9833)
renovate[bot] Nov 21, 2023
d725eb3
chore(deps): update devdependencies (#9837)
renovate[bot] Nov 29, 2023
5fb78ef
fix link to patternfly community contributors document (#9840)
yurith-rubio Nov 29, 2023
046ee9e
chore(deps): update devdependencies (#9846)
renovate[bot] Dec 5, 2023
eb9693f
fix(Table): make tooltip prop consistent (#9803)
kmcfaul Dec 6, 2023
ddc87a7
chore(DataList): convert data list react demo to TS (#9818)
jenny-s51 Dec 6, 2023
9244cf0
fix(AlertGroupDemo): crashed when adding default alerts (#9826)
MariaAga Dec 6, 2023
716c894
chore(release): releasing packages [ci skip]
patternfly-build Dec 6, 2023
fc55516
chore(deps): update dependency @types/jest to v29.5.11 (#9854)
renovate[bot] Dec 6, 2023
65912ac
Update Popover returnFocusOnDeactivate prop (#9865)
jschuler Dec 7, 2023
c9ead43
chore(release): releasing packages [ci skip]
patternfly-build Dec 7, 2023
bb58f8b
chore(deps): update dependency @patternfly/patternfly to v5.2.0-prere…
renovate[bot] Dec 11, 2023
5aa83c5
chore(release): releasing packages [ci skip]
patternfly-build Dec 11, 2023
6d065fd
chore(deps): update devdependencies (#9873)
renovate[bot] Dec 12, 2023
2afb5fd
fix(MenuItem): Add download to MenuItem (#9892)
rhamilto Dec 14, 2023
2ae9642
chore(release): releasing packages [ci skip]
patternfly-build Dec 14, 2023
ca5126e
chore(rebase): Rebase v6 branch
tlabaj Dec 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ If you want to start with your existing project, skip to [Install and configure
Once the library is installed, use the specific setup instructions for that library to access the components it contains. These can be found in the readme for each [library](#patternfly-react-packages).

### Contribution guidelines
All React contributors must first be [PatternFly community contributors](https://www.patternfly.org/contribute/about). If you're already a PatternFly community contributor, check out the [React contribution guidelines](https://github.com/patternfly/patternfly-react/tree/main/CONTRIBUTING.md) to make React contributions.
All React contributors must first be [PatternFly community contributors](https://www.patternfly.org/get-started/contribute/contributing-to-patternfly). If you're already a PatternFly community contributor, check out the [React contribution guidelines](https://github.com/patternfly/patternfly-react/tree/main/CONTRIBUTING.md) to make React contributions.


### License
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "14.5.1",
"@types/jest": "29.5.8",
"@types/jest": "29.5.11",
"@types/react": "^18",
"@types/react-dom": "^18",
"@typescript-eslint/eslint-plugin": "^5.59.2",
Expand Down
12 changes: 12 additions & 0 deletions packages/react-charts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,18 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.8 (2023-12-11)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.7 (2023-11-10)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.6 (2023-11-03)

**Note:** Version bump only for package @patternfly/react-charts

# 7.2.0-prerelease.5 (2023-10-26)

**Note:** Version bump only for package @patternfly/react-charts
Expand Down
68 changes: 68 additions & 0 deletions packages/react-code-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,74 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.36](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.35...@patternfly/react-code-editor@5.2.0-prerelease.36) (2023-12-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.35](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.34...@patternfly/react-code-editor@5.2.0-prerelease.35) (2023-12-11)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.34](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.33...@patternfly/react-code-editor@5.2.0-prerelease.34) (2023-12-07)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.33](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.32...@patternfly/react-code-editor@5.2.0-prerelease.33) (2023-12-06)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.32](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.31...@patternfly/react-code-editor@5.2.0-prerelease.32) (2023-11-21)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.31](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.30...@patternfly/react-code-editor@5.2.0-prerelease.31) (2023-11-17)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.30](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.29...@patternfly/react-code-editor@5.2.0-prerelease.30) (2023-11-16)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.29](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.28...@patternfly/react-code-editor@5.2.0-prerelease.29) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.28](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.27...@patternfly/react-code-editor@5.2.0-prerelease.28) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.27](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.26...@patternfly/react-code-editor@5.2.0-prerelease.27) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.26](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.25...@patternfly/react-code-editor@5.2.0-prerelease.26) (2023-11-13)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.25](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.24...@patternfly/react-code-editor@5.2.0-prerelease.25) (2023-11-10)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.24](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.23...@patternfly/react-code-editor@5.2.0-prerelease.24) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.23](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.22...@patternfly/react-code-editor@5.2.0-prerelease.23) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.22](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.21...@patternfly/react-code-editor@5.2.0-prerelease.22) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.21](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.20...@patternfly/react-code-editor@5.2.0-prerelease.21) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.20](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.19...@patternfly/react-code-editor@5.2.0-prerelease.20) (2023-11-02)

**Note:** Version bump only for package @patternfly/react-code-editor

# [5.2.0-prerelease.19](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-code-editor@5.2.0-prerelease.18...@patternfly/react-code-editor@5.2.0-prerelease.19) (2023-10-30)

**Note:** Version bump only for package @patternfly/react-code-editor
Expand Down
94 changes: 94 additions & 0 deletions packages/react-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,100 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline

- **RTL:** added right-to-left page demo ([#9694](https://github.com/patternfly/patternfly-react/issues/9694)) ([d7308ae](https://github.com/patternfly/patternfly-react/commit/d7308aebec1e3ff22df548b5613f058c9ba35262))

# [5.2.0-prerelease.36](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.35...@patternfly/react-core@5.2.0-prerelease.36) (2023-12-14)

### Bug Fixes

- **MenuItem:** Add download to MenuItem ([#9892](https://github.com/patternfly/patternfly-react/issues/9892)) ([2afb5fd](https://github.com/patternfly/patternfly-react/commit/2afb5fdeb8ade43aee6dadaccf9067a0939212c7))

# [5.2.0-prerelease.35](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.34...@patternfly/react-core@5.2.0-prerelease.35) (2023-12-11)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.34](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.33...@patternfly/react-core@5.2.0-prerelease.34) (2023-12-07)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.33](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.32...@patternfly/react-core@5.2.0-prerelease.33) (2023-12-06)

### Bug Fixes

- **AlertGroupDemo:** crashed when adding default alerts ([#9826](https://github.com/patternfly/patternfly-react/issues/9826)) ([9244cf0](https://github.com/patternfly/patternfly-react/commit/9244cf07bd599f295d623a6e37e8d15b3c7c3d40))

# [5.2.0-prerelease.32](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.31...@patternfly/react-core@5.2.0-prerelease.32) (2023-11-21)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.31](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.30...@patternfly/react-core@5.2.0-prerelease.31) (2023-11-17)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.30](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.29...@patternfly/react-core@5.2.0-prerelease.30) (2023-11-16)

### Bug Fixes

- **Chip:** update tooltip vis when chip updates ([#9819](https://github.com/patternfly/patternfly-react/issues/9819)) ([18c140a](https://github.com/patternfly/patternfly-react/commit/18c140a2adcc1833e4b095755aa7495d1d88a177))

# [5.2.0-prerelease.29](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.28...@patternfly/react-core@5.2.0-prerelease.29) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.28](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.27...@patternfly/react-core@5.2.0-prerelease.28) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.27](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.26...@patternfly/react-core@5.2.0-prerelease.27) (2023-11-14)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.26](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.25...@patternfly/react-core@5.2.0-prerelease.26) (2023-11-13)

### Bug Fixes

- **DatePicker:** updated logic for parsing and focus management ([#9794](https://github.com/patternfly/patternfly-react/issues/9794)) ([a12cf31](https://github.com/patternfly/patternfly-react/commit/a12cf313f0924a61a8cf20ee78b4b27290b9c05f))

# [5.2.0-prerelease.25](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.24...@patternfly/react-core@5.2.0-prerelease.25) (2023-11-10)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.24](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.23...@patternfly/react-core@5.2.0-prerelease.24) (2023-11-03)

### Bug Fixes

- **ClipboardCopy:** kepp caret position ([#9772](https://github.com/patternfly/patternfly-react/issues/9772)) ([981361e](https://github.com/patternfly/patternfly-react/commit/981361e0de354bbe06c4a799b6e7c92228dab51f))

### Features

- **Datalist:** implement full page Basic demo to match HTML [#9048](https://github.com/patternfly/patternfly-react/issues/9048) ([#9087](https://github.com/patternfly/patternfly-react/issues/9087)) ([ab18059](https://github.com/patternfly/patternfly-react/commit/ab1805993ed5e2b5ed3d2f1be4131e035152b468))

# [5.2.0-prerelease.23](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.22...@patternfly/react-core@5.2.0-prerelease.23) (2023-11-03)

**Note:** Version bump only for package @patternfly/react-core

# [5.2.0-prerelease.22](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.21...@patternfly/react-core@5.2.0-prerelease.22) (2023-11-02)

### Bug Fixes

- **TreeView:** define button type ([#9770](https://github.com/patternfly/patternfly-react/issues/9770)) ([a772c6d](https://github.com/patternfly/patternfly-react/commit/a772c6d67bfa4154979ee14a34ec954406503109))

# [5.2.0-prerelease.21](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.20...@patternfly/react-core@5.2.0-prerelease.21) (2023-11-02)

### Bug Fixes

- **Notification Drawer:** Added screen reader text for notification drawer item read state ([#9569](https://github.com/patternfly/patternfly-react/issues/9569)) ([bc19f91](https://github.com/patternfly/patternfly-react/commit/bc19f9148e872fb62d8cd2bf644a771d9c5650d7))
- **Text input:** Added aria-expanded ([#9705](https://github.com/patternfly/patternfly-react/issues/9705)) ([7f6a62c](https://github.com/patternfly/patternfly-react/commit/7f6a62c1a3f860a8759c63cde17da6b763dd7b48))
- **Wizard:** onStepChange - skip isDisabled & isHidden ([#9748](https://github.com/patternfly/patternfly-react/issues/9748)) ([4d4d623](https://github.com/patternfly/patternfly-react/commit/4d4d623d294bbc7821c6dc9156980f2b8c609c96))

### Features

- **Wizard:** ability to add props to WizardFooter buttons ([#9709](https://github.com/patternfly/patternfly-react/issues/9709)) ([9f21cee](https://github.com/patternfly/patternfly-react/commit/9f21cee5438c8ec4d0e2c5c938f9fffda013757b))

# [5.2.0-prerelease.20](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.19...@patternfly/react-core@5.2.0-prerelease.20) (2023-11-02)

### Bug Fixes

- **RTL:** added right-to-left page demo ([#9694](https://github.com/patternfly/patternfly-react/issues/9694)) ([d7308ae](https://github.com/patternfly/patternfly-react/commit/d7308aebec1e3ff22df548b5613f058c9ba35262))

# [5.2.0-prerelease.19](https://github.com/patternfly/patternfly-react/compare/@patternfly/react-core@5.2.0-prerelease.18...@patternfly/react-core@5.2.0-prerelease.19) (2023-10-30)

**Note:** Version bump only for package @patternfly/react-core
Expand Down
6 changes: 5 additions & 1 deletion packages/react-core/src/components/Menu/MenuItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export interface MenuItemProps extends Omit<React.HTMLProps<HTMLLIElement>, 'onC
target?: string;
/** Navigation link relationship. Only set when the to property is present. */
rel?: string;
/** Navigation link download. Only set when the to property is present. */
download?: string;
/** Flag indicating the item has a checkbox */
hasCheckbox?: boolean;
/** Flag indicating whether the item is active */
Expand Down Expand Up @@ -119,6 +121,7 @@ const MenuItemBase: React.FunctionComponent<MenuItemProps> = ({
tooltipProps,
rel,
target,
download,
...props
}: MenuItemProps) => {
const {
Expand Down Expand Up @@ -271,7 +274,8 @@ const MenuItemBase: React.FunctionComponent<MenuItemProps> = ({
// prevent invalid 'disabled' attribute on <a> tags
disabled: null,
target: isExternalLink ? '_blank' : target,
rel
rel,
download
};
} else if (Component === 'button') {
additionalProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Popover/Popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ export const Popover: React.FunctionComponent<PopoverProps> = ({
ref={popoverRef}
active={focusTrapActive}
focusTrapOptions={{
returnFocusOnDeactivate: true,
returnFocusOnDeactivate: propWithFocusTrap !== false,
clickOutsideDeactivates: true,
// FocusTrap's initialFocus can accept false as a value to prevent initial focus.
// We want to prevent this in case false is ever passed in.
Expand Down
Loading
Loading