CUSTCOM-75 Fix Payara System Property REST API #4497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows instance property overrides to be created without deleting all the other instance properties by using the REST endpoint correctly. It also allows empty property fields to be submitted to remove the property. Firstly the PUT and POST methods were the wrong way around, so they've been swapped. Secondly, the POST method didn't allow empty fields, which meant that instance property overrides couldn't be removed. To stop this, empty properties are now treated as properties to be removed. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
Added some javadocs for the class methods, and made a minor refactor to one method signature. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
The page title didn't have the parameter filled. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
The @NotMicroCompatible and @SincePayara annotations should be inherited when abstract test classes are annotated with them. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
This commit adds a set of tests for the system-properties endpoint of the REST management interface, to make sure that it responds correctly to PUT and POST requests. An arquillian extension has been added to allow temporary instances to be created for the purposes of tests. Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
|
jenkins test please |
AlanRoth
approved these changes
Feb 21, 2020
dmatej
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix.
This change allows instance property overrides to be created without deleting all the other instance properties by using the REST endpoint correctly. It also allows empty property fields to be submitted to remove the property.
Firstly the PUT and POST methods were the wrong way around, so they've been swapped. Secondly, the POST method didn't allow empty fields, which meant that instance property overrides couldn't be removed. To stop this, empty properties are now treated as properties to be removed.
Testing
Testing Performed
Setting up domain with:
From the admin console tried:
Test suites executed
N/A