Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-75 Fix Payara System Property REST API #4497

Merged
merged 5 commits into from
Feb 21, 2020
Merged

CUSTCOM-75 Fix Payara System Property REST API #4497

merged 5 commits into from
Feb 21, 2020

Commits on Feb 17, 2020

  1. CUSTCOM-75 Fix system prop page REST functionality

    This change allows instance property overrides to be created without
    deleting all the other instance properties by using the REST endpoint
    correctly. It also allows empty property fields to be submitted to
    remove the property.
    
    Firstly the PUT and POST methods were the wrong way around, so they've
    been swapped. Secondly, the POST method didn't allow empty fields, which
    meant that instance property overrides couldn't be removed. To stop
    this, empty properties are now treated as properties to be removed.
    
    Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
    MattGill98 committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    f1df5da View commit details
    Browse the repository at this point in the history
  2. SystemPropertiesCliResource refactor and javadoc

    Added some javadocs for the class methods, and made a minor refactor to
    one method signature.
    
    Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
    MattGill98 committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    81ba07a View commit details
    Browse the repository at this point in the history
  3. Fix admin console sysprop page title

    The page title didn't have the parameter filled.
    
    Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
    MattGill98 committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b3d475b View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Make Payara test annotations inheritable

    The @NotMicroCompatible and @SincePayara annotations should be inherited
    when abstract test classes are annotated with them.
    
    Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
    MattGill98 committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    95227b5 View commit details
    Browse the repository at this point in the history
  2. CUSTCOM-75 Add tests for system property endpoint

    This commit adds a set of tests for the system-properties endpoint of
    the REST management interface, to make sure that it responds correctly
    to PUT and POST requests.
    
    An arquillian extension has been added to allow temporary instances to
    be created for the purposes of tests.
    
    Signed-off-by: Matt Gill <matthew.gill@live.co.uk>
    MattGill98 committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    10e241b View commit details
    Browse the repository at this point in the history