Support for Rails 7.1 (#111)

* allow rails 7.1 * Update ci.yml * Create rails_7.1.gemfile * Update version.rb * update rubocop file * dev branch of active_attr * bye bye ruby 2.6 * updte rubocop * bye bye rails 4.2 * oups * we need this * one was missing * fix version check * ruby 3.0 only for rails 7.1 * rails 7.1 on ruby 3.1+ only * used released active_attr
payrollhero · Oct 30, 2023 · a8def4f · a8def4f
1 parent d34a46a
commit a8def4f
Show file tree

Hide file tree

Showing 8 changed files with 121 additions and 369 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -17,33 +17,23 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        gemfile: ["rails_7.0"]
-        ruby: [2.7]
+        gemfile: ['rails_7.0', 'rails_7.1']
+        ruby: [3.3, 3.2, 3.1]
         include:
           - gemfile: rails_7.0
-            ruby: '3.1'
-          - gemfile: rails_6.1
-            ruby: '3.1'
-          - gemfile: rails_7.0
-            ruby: '3.0'
-          - gemfile: rails_6.1
             ruby: '3.0'
-          - gemfile: rails_6.1
+          - gemfile: rails_7.0
             ruby: 2.7
           - gemfile: rails_6.1
-            ruby: 2.6
-          - gemfile: rails_6.0
             ruby: 2.7
           - gemfile: rails_6.0
-            ruby: 2.6
+            ruby: 2.7
           - gemfile: rails_5.2
-            ruby: 2.6
+            ruby: 2.7
           - gemfile: rails_5.1
-            ruby: 2.6
+            ruby: 2.7
           - gemfile: rails_5.0
-            ruby: 2.6
-          - gemfile: rails_4.2
-            ruby: 2.6
+            ruby: 2.7
 
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,18 +1,32 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 180`
-# on 2023-03-31 21:57:32 UTC using RuboCop version 1.48.1.
+# on 2023-10-30 03:57:18 UTC using RuboCop version 1.57.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'gemfiles/rails_7.1.gemfile'
+
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
     - 'lib/webhook_system/subscription.rb'
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/RedundantDirGlobSort:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
 # Offense count: 1
 Lint/UnreachableCode:
   Exclude:
@@ -23,21 +37,20 @@ Lint/UnreachableCode:
 Metrics/MethodLength:
   Max: 18
 
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, BlockForwardingName.
-# SupportedStyles: anonymous, explicit
-Naming/BlockForwarding:
-  Exclude:
-    - 'lib/webhook_system/base_event.rb'
-
 # Offense count: 1
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'lib/webhook_system/encoder.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'spec/support/rails_seven_one.rb'
+
 # Offense count: 9
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
@@ -68,6 +81,16 @@ RSpec/FilePath:
     - 'spec/event_spec.rb'
     - 'spec/models_spec.rb'
 
+# Offense count: 11
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/dispatching_events_spec.rb'
+    - 'spec/encoder_spec.rb'
+    - 'spec/event_spec.rb'
+    - 'spec/integration_spec.rb'
+    - 'spec/models_spec.rb'
+
 # Offense count: 3
 RSpec/LetSetup:
   Exclude:
@@ -80,6 +103,20 @@ RSpec/MatchArray:
   Exclude:
     - 'spec/models_spec.rb'
 
+# Offense count: 10
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: hash, symbol
+RSpec/MetadataStyle:
+  Exclude:
+    - 'spec/dispatching_events_spec.rb'
+    - 'spec/encoder_spec.rb'
+    - 'spec/event_log_spec.rb'
+    - 'spec/event_spec.rb'
+    - 'spec/integration_spec.rb'
+    - 'spec/models_spec.rb'
+    - 'spec/spec_helper.rb'
+
 # Offense count: 15
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
@@ -98,10 +135,21 @@ RSpec/NestedGroups:
   Max: 4
 
 # Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
 RSpec/ScatteredSetup:
   Exclude:
     - 'spec/models_spec.rb'
 
+# Offense count: 4
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'spec/encoder_spec.rb'
+    - 'spec/event_log_spec.rb'
+    - 'spec/event_spec.rb'
+    - 'spec/models_spec.rb'
+
 # Offense count: 2
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
@@ -121,19 +169,21 @@ Style/Documentation:
     - 'lib/webhook_system.rb'
     - 'lib/webhook_system/encoder.rb'
     - 'lib/webhook_system/subscription_topic.rb'
+    - 'spec/support/rails_seven_one.rb'
 
-# Offense count: 19
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-# SupportedShorthandSyntax: always, never, either, consistent
-Style/HashSyntax:
+Style/MultilineIfModifier:
   Exclude:
-    - 'lib/webhook_system/encoder.rb'
-    - 'spec/dispatching_events_spec.rb'
-    - 'spec/encoder_spec.rb'
-    - 'spec/event_log_spec.rb'
-    - 'spec/event_spec.rb'
+    - 'spec/support/rails_seven_one.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
+# SupportedStyles: compact, exploded
+Style/RaiseArgs:
+  Exclude:
+    - 'spec/support/rails_seven_one.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
@@ -154,3 +204,11 @@ Style/RedundantFreeze:
 Style/RegexpLiteral:
   Exclude:
     - 'spec/dispatching_events_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Exclude:
+    - 'spec/support/rails_seven_one.rb'
diff --git a/gemfiles/rails_4.2.gemfile b/gemfiles/rails_4.2.gemfile