Support for Rails 7.1 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenchaw
reviewed
Oct 30, 2023
| # assert_nothing_raised do | ||
| # perform_service(param: 'no_exception') | ||
| # end | ||
| def assert_nothing_raised |
There was a problem hiding this comment.
Why did this need patching?
There was a problem hiding this comment.
"Why?" is unclear, but I get NoMethodError assert with rails 7.1
smshuja
pushed a commit
to TheTalentEnterprise/webhook_system
that referenced
this pull request
Jan 25, 2024
* allow rails 7.1 * Update ci.yml * Create rails_7.1.gemfile * Update version.rb * update rubocop file * dev branch of active_attr * bye bye ruby 2.6 * updte rubocop * bye bye rails 4.2 * oups * we need this * one was missing * fix version check * ruby 3.0 only for rails 7.1 * rails 7.1 on ruby 3.1+ only * used released active_attr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.