-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format bare gives no error when trying to import another parser #490
Comments
I don't think we can change the default format in the API; that would break existing code. |
you are totally right, it could be done with the next big version also because the fact that the CLI has |
Let's fix this, and we can then open another issue to revisit the default at the next breaking change. |
I'm not going to cut a release just for this, since there is a work-around. |
When trying to compile a file with peggy if you set the format to bare the import is simply ignored with no warning indicating that bare cannot import
Step to reproduce:
npx peggy path/to/file.peggy --format bare
)What should come out:
An error or warning that the import was ignored.
Maybe for the api change the default format to
commonjs
or throw an errorThe text was updated successfully, but these errors were encountered: