Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw errors when imports are used in unsupported formats #492

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Feb 25, 2024

Fixes #490

["from-mem"](https://github.com/peggyjs/from-mem/) project is used by
the Peggy CLI to resolve these issues, but note well its relatively severe
limitations.</p>
<p>All of the following are valid:</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is missing here or am i wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the format issue for the link. What else do you see?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing otherwise seems okay

@XenoS-ITA
Copy link
Contributor

otherwise seems ok, tested on windows as well and it works

@hildjj hildjj merged commit a3e17de into peggyjs:main Feb 25, 2024
9 checks passed
@hildjj hildjj deleted the imports-bare branch February 25, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format bare gives no error when trying to import another parser
2 participants