🐛 Accounting base64 encoding for resources size validation #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amit3200
approved these changes
Nov 28, 2024
ninadbstack
reviewed
Nov 28, 2024
rishigupta1599
changed the title
ninadbstack
approved these changes
Nov 28, 2024
Amit3200
approved these changes
Nov 28, 2024
rishigupta1599
changed the title
rishigupta1599
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources which were greater than 25 MB in size we want to skip them in resource array as they might fail to upload, but when we upload we do base64 encoding which increases the size but while validation we were not accounting for increase in size due to encoding.
Base64 has 33-37% increase in content size so we are reducing max size check by that much factor