Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Accounting base64 encoding for resources size validation #1803

Merged
merged 6 commits into from
Nov 28, 2024
Merged

🐛 Accounting base64 encoding for resources size validation #1803

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b01831e
Fixing logic of resources with size > 25MB not skipping
rishigupta1599 Nov 28, 2024
d94184b
removing pako gzip in client
rishigupta1599 Nov 28, 2024
c18b045
lint fix
rishigupta1599 Nov 28, 2024
038ee32
Making 0.67 factor
rishigupta1599 Nov 28, 2024
a567e18
changing factor
rishigupta1599 Nov 28, 2024
336aea4
changing comment
rishigupta1599 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/network.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import logger from '@percy/logger';
import mime from 'mime-types';
import { DefaultMap, createResource, hostnameMatches, normalizeURL, waitFor, decodeAndEncodeURLWithLogging } from './utils.js';

const MAX_RESOURCE_SIZE = 25 * (1024 ** 2); // 25MB
const MAX_RESOURCE_SIZE = 25 * (1024 ** 2) * 0.63; // 25MB, 0.63 factor for accounting for base64 encoding
const ALLOWED_STATUSES = [200, 201, 301, 302, 304, 307, 308];
const ALLOWED_RESOURCES = ['Document', 'Stylesheet', 'Image', 'Media', 'Font', 'Other'];
const ABORTED_MESSAGE = 'Request was aborted by browser';
Expand Down