-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark optional dependencies in package.xml. #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Once this PR is merged, I'll update #373 reflecting this change and personalrobotics/pr-cleanroom#14.
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 83.48% 83.46% -0.02%
==========================================
Files 197 197
Lines 5619 5619
==========================================
- Hits 4691 4690 -1
- Misses 928 929 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the readme and say that these needs to be uncommented for using some of of the underlying packages?
Looks like |
Here's another proposal for managing optional dependencies:
I've updated Edit: depends on personalrobotics/pr-cleanroom#16. |
Depends on personalrobotics/pr-cleanroom#14.
In the CI scripts, we should now run something like
where
OPTIONAL
is the name of the dependency group below.Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md