Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional dependencies if --required-only is set. #16

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

brianhou
Copy link
Contributor

Yet another proposal for dealing with optional dependencies (instead of #13, #14).

  • By default, all dependencies (including optional dependencies) are required.
  • Use <optional> tags (inside <export>) to mark which of the <depend>s are optional. Programmatically remove them from the set of dependencies if the --required-only flag is set in the internal-distro.py script.

Copy link
Member

@jslee02 jslee02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I have one suggestion though, which shouldn't block merging this PR.

@jslee02
Copy link
Member

jslee02 commented Apr 22, 2018

The suggestion was replacing the exception with a warning. But now I see raising exception would be better because, as @brianhou pointed in a local discussion, we'll never see this error since no one runs cleanroom locally.

Merging this PR.

@jslee02 jslee02 merged commit 349c3af into master Apr 22, 2018
@jslee02 jslee02 deleted the enhancement/brianhou/export-optional branch April 22, 2018 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants